Sign upLogin

rugk/threema-msgapi-sdk-php

View on GitHub
Star
source/Threema/Core/AssocArray.php

Summary

Maintainability
A
45 mins
Test Coverage

Function byJsonString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public static final function byJsonString($string, array $requiredKeys = null) {
        $v = json_decode($string, true);
        if(null === $v || false === $v) {
            throw new Exception('invalid json string');
        }
Severity: Minor
Found in source/Threema/Core/AssocArray.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid variables with short names like $v. Configured minimum length is 3.
Open

        $v = json_decode($string, true);
Severity: Minor
Found in source/Threema/Core/AssocArray.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status