source/Threema/MsgApi/PublicKeyStores/File.php
Function findPublicKey has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public function findPublicKey($threemaId) {
$storeHandle = fopen($this->file, 'r');
if(false === $storeHandle) {
throw new Exception('could not open file '.$this->file);
}- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method findPublicKey uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
else {
$threemaId = strtoupper($threemaId);
$publicKey = null;
while (!feof($storeHandle)) {
$buffer = fgets($storeHandle, 4096);- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}