source/Threema/MsgApi/PublicKeyStores/PhpFile.php
Method initFile has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private function initFile($fileHandle = null)
{
//check if file does already contain content
if (filesize($this->file) != 0) {
return true;- Create a ticketCreate a ticket
Function initFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
private function initFile($fileHandle = null)
{
//check if file does already contain content
if (filesize($this->file) != 0) {
return true;- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid unused local variables such as '$isMsgApiKeystore'. Open
Open
$isMsgApiKeystore = true;- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}