Sign upLogin

rugk/threema-msgapi-sdk-php

View on GitHub
Star
source/Threema/MsgApi/Tests/CommonTests.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Threema\Console\Common' in method 'testGetPrivateKey'.
Open

        $realPrivateKey = Common::getPrivateKey(Constants::myPrivateKey);
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'testConvertPublicKey'.
Open

        $p = Common::convertPublicKey('PUBKEYSTRING');
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'testConvertPrivateKey'.
Open

        $p = Common::convertPrivateKey('PRIVKEYSTRING');
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Threema\Console\Common' in method 'testGetPublicKey'.
Open

        $realPublicKey = Common::getPublicKey(Constants::myPublicKey);
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid variables with short names like $p. Configured minimum length is 3.
Open

        $p = Common::convertPrivateKey('PRIVKEYSTRING');
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $p. Configured minimum length is 3.
Open

        $p = Common::convertPublicKey('PUBKEYSTRING');
Severity: Minor
Found in source/Threema/MsgApi/Tests/CommonTests.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

There are no issues that match your filters.

Category
Status