Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star

Showing 597 of 597 total issues

The method _getExistingData is not named in camelCase.
Open

    protected function _getExistingData($data)
    {
        // try primary key first
        /** @var string $requestId */
        if ($requestId = $this->_getExistingPrimaryKey($data, 'request_id')) {
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/TfaPendingMessagesConfirmation.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getFields is not named in camelCase.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_Messages::DB_TABLE_MESSAGES => [
                'message_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUpdateCondition is not named in camelCase.
Open

    protected function _getUpdateCondition($tableName)
    {
        return 'message_id = ' . $this->_db->quote($this->getExisting('message_id'));
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getFields is not named in camelCase.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_ActionThrottle::DB_TABLE => [
                'action_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/ActionThrottle.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getMessagesModel is not named in camelCase.
Open

    protected function _getMessagesModel()
    {
        return $this->getModelFromCache('ThreemaGateway_Model_Messages');
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getExistingData is not named in camelCase.
Open

    protected function _getExistingData($data)
    {
        return [];
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _preDelete is not named in camelCase.
Open

    protected function _preDelete()
    {
        // we may need to store the message ID to prevent replay attacks
        if (ThreemaGateway_Helper_Message::isAtRiskOfReplayAttack($this->_existingData[ThreemaGateway_Model_Messages::DB_TABLE_MESSAGES])) {
            // remove main table from deletion as it is handled in _postDelete().
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getActionThrottleModel is not named in camelCase.
Open

    protected function _getActionThrottleModel()
    {
        return $this->getModelFromCache('ThreemaGateway_Model_ActionThrottle');
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/ActionThrottle.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUpdateCondition is not named in camelCase.
Open

    protected function _getUpdateCondition($tableName)
    {
        return '';
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getUpdateCondition is not named in camelCase.
Open

    protected function _getUpdateCondition($tableName)
    {
        return 'request_id = ' . $this->_db->quote($this->getExisting('request_id'));
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/TfaPendingMessagesConfirmation.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getExistingData is not named in camelCase.
Open

    protected function _getExistingData($data)
    {
        return [];
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/ActionThrottle.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getFields is not named in camelCase.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_TfaPendingMessagesConfirmation::DB_TABLE => [
                'request_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/TfaPendingMessagesConfirmation.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getFields is not named in camelCase.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_Keystore::DB_TABLE => [
                'threema_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getExistingData is not named in camelCase.
Open

    protected function _getExistingData($data)
    {
        /** @var string $messageId */
        if (!$messageId = $this->_getExistingPrimaryKey($data, 'message_id')) {
            return false;
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Messages.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getPendingConfirmMsgModel is not named in camelCase.
Open

    protected function _getPendingConfirmMsgModel()
    {
        return $this->getModelFromCache('ThreemaGateway_Model_TfaPendingMessagesConfirmation');
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/TfaPendingMessagesConfirmation.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getTfaModel is not named in camelCase.
Open

    protected function _getTfaModel()
    {
        return $this->getModelFromCache('XenForo_Model_Tfa');
    }
Severity: Minor
Found in src/library/ThreemaGateway/ControllerPublic/Login.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getTfaModel is not named in camelCase.
Open

    protected function _getTfaModel()
    {
        return $this->getModelFromCache('XenForo_Model_Tfa');
    }
Severity: Minor
Found in src/library/ThreemaGateway/ControllerAdmin/Login.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language