Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/DataWriter/Keystore.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$data'.
Open

    protected function _getExistingData($data)
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$tableName'.
Open

    protected function _getUpdateCondition($tableName)
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

The method _getUpdateCondition is not named in camelCase.
Open

    protected function _getUpdateCondition($tableName)
    {
        return '';
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getFields is not named in camelCase.
Open

    protected function _getFields()
    {
        return [
            ThreemaGateway_Model_Keystore::DB_TABLE => [
                'threema_id' => [
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _getExistingData is not named in camelCase.
Open

    protected function _getExistingData($data)
    {
        return [];
    }
Severity: Minor
Found in src/library/ThreemaGateway/DataWriter/Keystore.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status