Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Handler/Action/Abstract.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '38', column '34').
Open

        $this->settings    = new ThreemaGateway_Handler_Settings;
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '89', column '20').
Open

        return new Threema\MsgApi\Receiver($value, $type);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class 'ThreemaGateway_Handler_Permissions' in method '__construct'.
Open

        $this->permissions = ThreemaGateway_Handler_Permissions::getInstance();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'ThreemaGateway_Handler_PhpSdk' in method 'getSdk'.
Open

            $this->sdk = ThreemaGateway_Handler_PhpSdk::getInstance($this->settings);
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/Abstract.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status