Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Handler/Action/GatewayServer.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '63', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '115', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '63', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '90', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '124', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_getting_credits_failed') . ' ' . $result->getErrorMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '28', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '90', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '153', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_fetching_publickey_failed') . ' ' . $result->getErrorMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '115', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '140', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '153', column '45').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_fetching_publickey_failed') . ' ' . $result->getErrorMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '28', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_permission_error'));
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '124', column '23').
Open

            throw new XenForo_Exception(new XenForo_Phrase('threemagw_getting_credits_failed') . ' ' . $result->getErrorMessage());
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method getCredits uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw new XenForo_Exception(new XenForo_Phrase('threemagw_getting_credits_failed') . ' ' . $result->getErrorMessage());
        }
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The method fetchPublicKey uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            throw new XenForo_Exception(new XenForo_Phrase('threemagw_fetching_publickey_failed') . ' ' . $result->getErrorMessage());
        }
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid excessively long class names like ThreemaGateway_Handler_Action_GatewayServer. Keep class name length under 40.
Open

class ThreemaGateway_Handler_Action_GatewayServer extends ThreemaGateway_Handler_Action_Abstract
{
    /**
     * Returns the Threema ID associated to a phone number.
     *
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Action/GatewayServer.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

There are no issues that match your filters.

Category
Status