src/library/ThreemaGateway/Handler/Action/KeyConverter.php
Avoid using static access to class 'ThreemaGateway_Helper_Key' in method 'hexToBin'. Open
Open
$keyHex = ThreemaGateway_Helper_Key::removeSuffix($keyHex);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
Avoid excessively long class names like ThreemaGateway_Handler_Action_KeyConverter. Keep class name length under 40. Open
Open
class ThreemaGateway_Handler_Action_KeyConverter extends ThreemaGateway_Handler_Action_Abstract
{
/**
* Converts a key from hex to binary format.
*- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}