Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Handler/PhpSdk.php

Summary

Maintainability
A
1 hr
Test Coverage

Method createConnectionSettings has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function createConnectionSettings($gatewayId, $gatewaySecret)
    {
        /** @var XenForo_Options $xenOptions */
        $xenOptions = XenForo_Application::getOptions();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/PhpSdk.php - About 1 hr to fix

    Avoid using undefined variables such as '$cryptTool' which will lead to PHP notices.
    Open

            $this->cryptTool       = $cryptTool;
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    The class ThreemaGateway_Handler_PhpSdk has a coupling between objects value of 15. Consider to reduce the number of dependencies under 13.
    Open

    class ThreemaGateway_Handler_PhpSdk
{
    /**
     * @var Singleton
     */
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '213', column '23').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_sdk'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '296', column '53').
    Open

                        throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_httpshardening_option'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '155', column '23').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_e2e_helper'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '213', column '45').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_sdk'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '233', column '29').
    Open

                $keystore = new ThreemaGateway_Handler_DbKeystore();
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '235', column '29').
    Open

                $keystore = new Threema\MsgApi\PublicKeyStores\PhpFile(__DIR__ . '/../' . $phpKeystore['path']);
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '76', column '35').
    Open

                $this->settings = new ThreemaGateway_Handler_Settings;
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '296', column '31').
    Open

                        throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_httpshardening_option'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '155', column '45').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_e2e_helper'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The method loadLib uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            // error
            throw new XenForo_Exception(new XenForo_Phrase('threemagw_missing_sdk'));
        }
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'XenForo_Application' in method 'createConnectionSettings'.
    Open

            $xenOptions = XenForo_Application::getOptions();
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $this->settings = new ThreemaGateway_Handler_Settings;
        }
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method createKeystore uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $keystore = new Threema\MsgApi\PublicKeyStores\PhpFile(__DIR__ . '/../' . $phpKeystore['path']);
        }
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'ThreemaGateway_Helper_Key' in method 'createConnection'.
    Open

                    $this->cryptTool->hex2bin(ThreemaGateway_Helper_Key::removeSuffix($this->settings->getPrivateKey())),
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/PhpSdk.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status