Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Handler/Settings.php

Summary

Maintainability
A
1 hr
Test Coverage

Function isReady has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function isReady()
    {
        // basic check
        if (!$this->isAvaliable()) {
            return false;
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Settings.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in src/library/ThreemaGateway/Handler/Settings.php - About 30 mins to fix

    Missing class import via use statement (line '212', column '36').
    Open

                $keyConverter    = new ThreemaGateway_Handler_Action_KeyConverter;
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '245', column '23').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_keystorepath'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '235', column '23').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_privatekey'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '235', column '45').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_privatekey'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '245', column '45').
    Open

                throw new XenForo_Exception(new XenForo_Phrase('threemagw_invalid_keystorepath'));
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'XenForo_Application' in method 'isDebug'.
    Open

            $xenOptions = XenForo_Application::getOptions();
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'XenForo_Application' in method 'isDebug'.
    Open

                XenForo_Application::debugMode());
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'XenForo_Application' in method '__construct'.
    Open

            $xenOptions = XenForo_Application::getOptions();
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ThreemaGateway_Helper_Key' in method 'isPrivateKey'.
    Open

            return ThreemaGateway_Helper_Key::check($privateKey, 'private:');
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'ThreemaGateway_Helper_Key' in method 'convertPrivateKey'.
    Open

            if (ThreemaGateway_Helper_Key::check($this->privateKeyBase, 'private:')) {
    Severity: Minor
    Found in src/library/ThreemaGateway/Handler/Settings.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    There are no issues that match your filters.

    Category
    Status