Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Handler/Validation.php

Summary

Maintainability
A
0 mins
Test Coverage

The method checkThreemaId has a boolean flag argument $checkExistence, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function checkThreemaId(&$threemaid, $type, &$error, $checkExistence = true)
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Missing class import via use statement (line '38', column '25').
Open

        $gwServer = new ThreemaGateway_Handler_Action_GatewayServer;
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '45', column '27').
Open

            $error = (new XenForo_Phrase('threemagw_threema_id_does_not_exist'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '29', column '27').
Open

            $error = (new XenForo_Phrase('threemagw_invalid_threema_id'))->render();
Severity: Minor
Found in src/library/ThreemaGateway/Handler/Validation.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

There are no issues that match your filters.

Category
Status