src/library/ThreemaGateway/Helper/General.php
The method roundToDayRelative has a boolean flag argument $roundUp, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public static function roundToDayRelative($minutes, $roundUp = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The method roundToDay has a boolean flag argument $roundUp, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public static function roundToDay($time, $roundUp = false)- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'ThreemaGateway_Handler_Validation' in method 'isThreemaId'. Open
Open
return ThreemaGateway_Handler_Validation::checkThreemaId($threemaid, $type, $error, $checkExistence);- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}