Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Installer/MessagesDb.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method create has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function create()
    {
        $db = XenForo_Application::get('db');

        // set charset
Severity: Major
Found in src/library/ThreemaGateway/Installer/MessagesDb.php - About 2 hrs to fix

    Avoid using static access to class 'XenForo_Application' in method 'create'.
    Open

            $db = XenForo_Application::get('db');
    Severity: Minor
    Found in src/library/ThreemaGateway/Installer/MessagesDb.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'XenForo_Application' in method 'destroy'.
    Open

            $db = XenForo_Application::get('db');
    Severity: Minor
    Found in src/library/ThreemaGateway/Installer/MessagesDb.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = XenForo_Application::get('db');
    Severity: Minor
    Found in src/library/ThreemaGateway/Installer/MessagesDb.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $db. Configured minimum length is 3.
    Open

            $db = XenForo_Application::get('db');
    Severity: Minor
    Found in src/library/ThreemaGateway/Installer/MessagesDb.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status