Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Model/ActionThrottle.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class 'XenForo_Application' in method 'getActionLimit'.
Open

        $xenOptions = XenForo_Application::getOptions();
Severity: Minor
Found in src/library/ThreemaGateway/Model/ActionThrottle.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'XenForo_DataWriter' in method 'logAction'.
Open

        $dataWriter = XenForo_DataWriter::create('ThreemaGateway_DataWriter_ActionThrottle');
Severity: Minor
Found in src/library/ThreemaGateway/Model/ActionThrottle.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status