rugk/xenforo-threema-gateway

View on GitHub
src/library/ThreemaGateway/Session.php

Summary

Maintainability
A
0 mins
Test Coverage

The method threemagwSetupRaw has a boolean flag argument $ipAddress, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function threemagwSetupRaw($sessionId = '', $ipAddress = false, array $defaultSession = null)

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status