Sign upLogin

rugk/xenforo-threema-gateway

View on GitHub
Star
src/library/ThreemaGateway/Tfa/Reversed.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method renderVerification has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function renderVerification(XenForo_View $view, $context, array $user,
                                        array $providerData, array $triggerData)
Severity: Minor
Found in src/library/ThreemaGateway/Tfa/Reversed.php - About 35 mins to fix

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in src/library/ThreemaGateway/Tfa/Reversed.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/library/ThreemaGateway/Tfa/Reversed.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in src/library/ThreemaGateway/Tfa/Reversed.php - About 30 mins to fix

          Missing class import via use statement (line '85', column '23').
          Open

                      throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '85', column '45').
          Open

                      throw new XenForo_Exception(new XenForo_Phrase('threema_this_action_required_e2e'));
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Missing class import via use statement (line '29', column '20').
          Open

                  return new XenForo_Phrase('tfa_' . $this->_providerId . '_desc', $params);
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          MissingImport

          Since: 2.7.0

          Importing all external classes in a file through use statements makes them clearly visible.

          Example

          function make() {
    return new \stdClass();
}

          Source http://phpmd.org/rules/cleancode.html#MissingImport

          Avoid using static access to class 'XenForo_Application' in method 'canEnable'.
          Open

                  $options = XenForo_Application::getOptions();
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method triggerVerification uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            $providerData['validationTime'] = $options->threema_gateway_tfa_reversed_validation * 60; //default: 3 minutes
        }
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class 'XenForo_Application' in method 'adjustViewParams'.
          Open

                  $xenOptions = XenForo_Application::getOptions();
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'ThreemaGateway_Helper_Emoji' in method 'renderVerification'.
          Open

                      $triggerData['secretWithSmiley'] = ThreemaGateway_Helper_Emoji::parseUnicode(
                ThreemaGateway_Helper_Emoji::replaceDigits($triggerData['secret'])
            );
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'XenForo_Application' in method 'renderVerification'.
          Open

                  $xenOptions = XenForo_Application::getOptions();
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'XenForo_Application' in method 'triggerVerification'.
          Open

                  $options = XenForo_Application::getOptions();
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'ThreemaGateway_Helper_Emoji' in method 'renderVerification'.
          Open

                          ThreemaGateway_Helper_Emoji::replaceDigits($triggerData['secret'])
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class 'XenForo_Application' in method 'getDescription'.
          Open

                  $options = XenForo_Application::getOptions();
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid unused parameters such as '$providerData'.
          Open

              protected function initiateSetupData(array &$providerData, array &$triggerData)
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$triggerData'.
          Open

              protected function initiateSetupData(array &$providerData, array &$triggerData)
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$context'.
          Open

              protected function adjustViewParams(array $viewParams, $context, array $user)
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          Avoid unused parameters such as '$user'.
          Open

              protected function adjustViewParams(array $viewParams, $context, array $user)
          Severity: Minor
          Found in src/library/ThreemaGateway/Tfa/Reversed.php by phpmd

          UnusedFormalParameter

          Since: 0.2

          Avoid passing parameters to methods or constructors and then not using those parameters.

          Example

          class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

          Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

          There are no issues that match your filters.

          Category
          Status