rusty1s/dotfiles

View on GitHub

Showing 27 of 27 total issues

Do not use a command that has unintended side effects
Open

  :silent! %s#\($\n\s*\)\+\%$##
Severity: Minor
Found in vim/autoload/trim.vim by vint

Google VimScript Style Guide (Dangerous)

Use scriptencoding when multibyte char exists
Open

set clipboard=unnamed
Severity: Minor
Found in vim/plugin/settings.vim by vint

:help :scriptencoding

Can't follow non-constant source. Use a directive to specify location.
Open

source "$HOME/dotfiles/ubuntu/.pathrc"
Severity: Minor
Found in ubuntu/conda.sh by shellcheck

Can't follow non-constant source. Use a directive to specify location.

Problematic code:

. "$(find_install_dir)/lib.sh"

Correct code:

# shellcheck source=src/lib.sh
. "$(find_install_dir)/lib.sh"

Rationale:

ShellCheck is not able to include sourced files from paths that are determined at runtime. The file will not be read, potentially resulting in warnings about unassigned variables and similar.

Use a [[Directive]] to point shellcheck to a fixed location it can read instead.

Exceptions:

If you don't care that ShellCheck is unable to account for the file, specify # shellcheck source=/dev/null.

Notice

Original content from the ShellCheck https://github.com/koalaman/shellcheck/wiki.

Use scriptencoding when multibyte char exists
Open

set statusline=                                " Start with a clean line.
Severity: Minor
Found in vim/plugin/statusline.vim by vint

:help :scriptencoding

Unordered list indentation
Open

   * Set `darkwake=8` to enable sleep
Severity: Info
Found in settings/hackintosh.md by markdownlint

MD007 - Unordered list indentation

Tags: bullet, ul, indentation

Aliases: ul-indent

Parameters: indent (number; default 2)

This rule is triggered when list items are not indented by the configured number of spaces (default: 2).

Example:

* List item
   * Nested list item indented by 3 spaces

Corrected Example:

* List item
  * Nested list item indented by 2 spaces

Rationale (2 space indent): indenting by 2 spaces allows the content of a nested list to be in line with the start of the content of the parent list when a single space is used after the list marker.

Rationale (4 space indent): Same indent as code blocks, simpler for editors to implement. See http://www.cirosantilli.com/markdown-styleguide/#indented-lists for more information.

In addition, this is a compatibility issue with multi-markdown parsers, which require a 4 space indents. See http://support.markedapp.com/discussions/problems/21-sub-lists-not-indenting for a description of the problem.

TODO found
Open

  # TODO: Symlink iterm2 config.
Severity: Minor
Found in terminal/main.sh by fixme

TODO found
Open

    # TODO: Show no useless brew errors.
Severity: Minor
Found in helper/brew.sh by fixme
Severity
Category
Status
Source
Language