Sign upLogin

ryansobol/mango

View on GitHub
Star

Showing 26 of 26 total issues

Function FireworkParticle has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

function FireworkParticle(oC,isRandom,type,baseX,baseY,obeyBoundaries) {
  var self = this;
  this.oC = oC;
  this.oID = 'fp'+(fc.gOID++); // may be unneeded
  this.o = fc.oFP.cloneNode(true);
Severity: Minor
Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File fireworks.js has 453 lines of code (exceeds 250 allowed). Consider refactoring.
Open

function FireworksController() {
  var self = this;
  this.intervalRate = 20; // rate (ms) to run animation at, general best default = 20
  this.DEBUG = true; // debug mode disabled by default
  this.oFW = null;
Severity: Minor
Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 6 hrs to fix

    Function Firework has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function Firework(oC,startX,startY,burstX,burstY,burstType,nRadius,nParticles,nCircles,allowRandom,obeyBoundaries) {
  var self = this;
  this.oID = 'fp'+(fc.gOID++); // may be unneeded
  var p = '';
  for (var i=0; i<arguments.length-1; i++) {
    Severity: Major
    Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 4 hrs to fix

      Function FireworkParticle has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function FireworkParticle(oC,isRandom,type,baseX,baseY,obeyBoundaries) {
  var self = this;
  this.oC = oC;
  this.oID = 'fp'+(fc.gOID++); // may be unneeded
  this.o = fc.oFP.cloneNode(true);
      Severity: Major
      Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 4 hrs to fix

        Function Firework has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        function Firework(oC,startX,startY,burstX,burstY,burstType,nRadius,nParticles,nCircles,allowRandom,obeyBoundaries) {
  var self = this;
  this.oID = 'fp'+(fc.gOID++); // may be unneeded
  var p = '';
  for (var i=0; i<arguments.length-1; i++) {
        Severity: Minor
        Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function FireworksController has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        function FireworksController() {
  var self = this;
  this.intervalRate = 20; // rate (ms) to run animation at, general best default = 20
  this.DEBUG = true; // debug mode disabled by default
  this.oFW = null;
        Severity: Minor
        Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Animator has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        function Animator() {
  var self = this;
  writeDebug('Animator()');
  this.tweens = [];
  this.tweens['default'] = [1,2,3,4,5,6,7,8,9,10,9,8,7,6,5,4,3,2,1];
        Severity: Minor
        Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createFirework has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
        Open

        function createFirework(nRadius,nParticles,nCircles,nBurstType,startX,startY,burstX,burstY,allowRandom,obeyBoundaries) {
  // check all arguments, supply random defaults if needed
  var tmp = '';
  for (var i in arguments) {
    tmp += i+',';
        Severity: Minor
        Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Animator has 68 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function Animator() {
  var self = this;
  writeDebug('Animator()');
  this.tweens = [];
  this.tweens['default'] = [1,2,3,4,5,6,7,8,9,10,9,8,7,6,5,4,3,2,1];
        Severity: Major
        Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 2 hrs to fix

          Function FireworksController has 64 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function FireworksController() {
  var self = this;
  this.intervalRate = 20; // rate (ms) to run animation at, general best default = 20
  this.DEBUG = true; // debug mode disabled by default
  this.oFW = null;
          Severity: Major
          Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 2 hrs to fix

            Function createFirework has 51 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function createFirework(nRadius,nParticles,nCircles,nBurstType,startX,startY,burstX,burstY,allowRandom,obeyBoundaries) {
  // check all arguments, supply random defaults if needed
  var tmp = '';
  for (var i in arguments) {
    tmp += i+',';
            Severity: Major
            Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 2 hrs to fix

              Function Firework has 11 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function Firework(oC,startX,startY,burstX,burstY,burstType,nRadius,nParticles,nCircles,allowRandom,obeyBoundaries) {
              Severity: Major
              Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 1 hr to fix

                Method initialize has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                    def initialize(options = {})
      data   = options[:data]   || ""
      engine = options[:engine] || DEFAULT_ATTRIBUTES["engine"]

      unless TEMPLATE_ENGINES.include?(engine)
                Severity: Minor
                Found in lib/mango/content_page.rb - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createFirework has 10 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function createFirework(nRadius,nParticles,nCircles,nBurstType,startX,startY,burstX,burstY,allowRandom,obeyBoundaries) {
                Severity: Major
                Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (self.frame++>=self.tween.length) {
      self.active = false;
      self.frame = 0;
      if (self._oncomplete) self._oncomplete();
      self._oncomplete = null;
                  Severity: Major
                  Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js and 1 other location - About 1 hr to fix
                  lib/mango/templates/themes/default/public/javascripts/fireworks.js on lines 166..172

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (self.frame++>=self.tween[0].length-1) {
      self.active = false;
      self.frame = 0;
      if (self._oncomplete) self._oncomplete();
      self._oncomplete = null;
                  Severity: Major
                  Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js and 1 other location - About 1 hr to fix
                  lib/mango/templates/themes/default/public/javascripts/fireworks.js on lines 140..146

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def render_javascript_template!(uri_path)
      javascript_match = File.join(settings.javascripts, "*")
      javascript_path  = File.expand_path(uri_path, settings.javascripts)

      return unless File.fnmatch(javascript_match, javascript_path)
                  Severity: Major
                  Found in lib/mango/application.rb and 1 other location - About 1 hr to fix
                  lib/mango/application.rb on lines 425..435

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      def render_stylesheet_template!(uri_path)
      stylesheet_match = File.join(settings.stylesheets, "*")
      stylesheet_path  = File.expand_path(uri_path, settings.stylesheets)

      return unless File.fnmatch(stylesheet_match, stylesheet_path)
                  Severity: Major
                  Found in lib/mango/application.rb and 1 other location - About 1 hr to fix
                  lib/mango/application.rb on lines 355..365

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function slideTo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    this.slideTo = function(x1,y1) {
    // writeDebug('slideTo (x/y): '+x1+','+y1);
    if (self.isRandom) {
      // randomize a bit
      x1 += (x1*0.2*(Math.random()>0.5?1:-1));
                  Severity: Minor
                  Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 1 hr to fix

                    Function FireworkParticle has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function FireworkParticle(oC,isRandom,type,baseX,baseY,obeyBoundaries) {
                    Severity: Minor
                    Found in lib/mango/templates/themes/default/public/javascripts/fireworks.js - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language