Sign upLogin

rycus86/domain-automation

View on GitHub
Star

Showing 14 of 14 total issues

Function update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def update(self, subdomain):
        try:
            with open('.cloudflare.ini', 'w') as cloudflare_config:
                cloudflare_config.write('dns_cloudflare_email = %s\n' % self.cf_email)
                cloudflare_config.write('dns_cloudflare_api_key = %s\n' % self.cf_token)
Severity: Minor
Found in src/ssl_manager/certbot_cf_ssl.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if record and record['content'] == public_ip and record['name'] == subdomain.full:
                dns_records_created.inc()

                return 'OK, created [%s]' % public_ip
Severity: Major
Found in src/dns_manager/cloudflare_dns.py and 1 other location - About 2 hrs to fix
src/dns_manager/cloudflare_dns.py on lines 95..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if record and record['content'] == public_ip and record['name'] == subdomain.full:
                dns_records_updated.inc()

                return 'OK, updated [%s]' % public_ip
Severity: Major
Found in src/dns_manager/cloudflare_dns.py and 1 other location - About 2 hrs to fix
src/dns_manager/cloudflare_dns.py on lines 115..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function process_events has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def process_events(self, since, until):
        for event in self.client.events(decode=True, since=since, until=until):
            if self.cancelled:
                break
Severity: Minor
Found in src/scheduler/repeat_docker.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _iter_subdomains has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def _iter_subdomains(self):
        if len(self.client.swarm.attrs) > 0:
            for service in self.client.services.list():
                labels = service.attrs['Spec'].get('Labels', dict())
Severity: Minor
Found in src/discovery/docker_labels.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def check(subdomain, public_ip, dns, ssl, notifications):
    if dns.needs_update(subdomain, public_ip):
        try:
            dns_result = dns.update(subdomain, public_ip)
Severity: Minor
Found in src/app.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _send_signal_in_swarm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _send_signal_in_swarm(self):
        current_container_id = get_current_container_id()
        if not current_container_id:
            return
Severity: Minor
Found in src/notifications/docker_signal.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function check has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def check(subdomain, public_ip, dns, ssl, notifications):
Severity: Minor
Found in src/app.py - About 35 mins to fix

    Function send_message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def send_message(self, message, retry=1):
        if retry > 3:
            logger.error('Giving up on Slack message: %s' % message)
            return
    Severity: Minor
    Found in src/notifications/slack_message.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    return self.RESULT_NOT_YET_DUE_FOR_RENEWAL
    Severity: Major
    Found in src/ssl_manager/certbot_cf_ssl.py - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def ssl_updated(self, subdomain, result):
        for delegate in self.delegates:
            with _ignore_errors():
                delegate.ssl_updated(subdomain, result)
      Severity: Minor
      Found in src/notifications/__init__.py and 1 other location - About 30 mins to fix
      src/notifications/__init__.py on lines 25..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

                      return 'Unknown'
      Severity: Major
      Found in src/ssl_manager/certbot_cf_ssl.py - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            def dns_updated(self, subdomain, result):
        for delegate in self.delegates:
            with _ignore_errors():
                delegate.dns_updated(subdomain, result)
        Severity: Minor
        Found in src/notifications/__init__.py and 1 other location - About 30 mins to fix
        src/notifications/__init__.py on lines 30..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function _iter_labels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def _iter_labels(self, labels):
        for name, value in labels.items():
            if name in self.label_names:
                for domain_name in value.split(','):
                    yield self._to_subdomain(domain_name.strip())
        Severity: Minor
        Found in src/discovery/docker_labels.py - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language