Sign upLogin

saasbook/esaas-engagements

View on GitHub
Star

Showing 71 of 71 total issues

Method propose has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def propose(team, team_preferences)
      team_preferences.each do |app|
        puts "Team preferences: " + team_preferences.to_s
        puts "Team " + team + " proposing to App " + app
        # Check if the app is currently matched
Severity: Minor
Found in app/models/matching.rb - About 1 hr to fix

    Method create_engagement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
    Severity: Minor
    Found in app/controllers/matching_controller.rb - About 1 hr to fix

      Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create
    # check if student is already in an existing engagement
    # check if team_number is unique
    seen = []
    team_numbers = []
      Severity: Minor
      Found in app/controllers/matching_controller.rb - About 1 hr to fix

        Method update_engagement has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def update_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
        Severity: Minor
        Found in app/controllers/matching_controller.rb - About 1 hr to fix

          Method create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
    # check if student is already in an existing engagement
    # check if team_number is unique
    seen = []
    team_numbers = []
          Severity: Minor
          Found in app/controllers/matching_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method results has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            def results
    keyword = params["keyword"]
    @filters = session[:filters]
    @apps = []
    @orgs = []
          Severity: Minor
          Found in app/controllers/search_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method results has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def results
    keyword = params["keyword"]
    @filters = session[:filters]
    @apps = []
    @orgs = []
          Severity: Minor
          Found in app/controllers/search_controller.rb - About 1 hr to fix

            Method auth_matching has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def auth_matching
    @@name_path = request.env['PATH_INFO']
    if current_user&.client?
      begin
        redirect_to :back, alert: "You do not have access to that page."
            Severity: Minor
            Found in app/controllers/application_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method create_engagement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

              def create_engagement
    @matching = Matching.find(params[:matching_id])
    if @matching.status == 'Completed'
      redirect_to matching_progress_path(params[:matching_id]), alert: 'Matching is already completed.'
      return
            Severity: Minor
            Found in app/controllers/matching_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method store has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def store
    @matching = Matching.find(params[:matching_id])
    @engagement = Engagement.find(params[:engagement_id])

    # Update last update users
            Severity: Minor
            Found in app/controllers/matching_controller.rb - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def create
    @app = App.new(app_params)

    respond_to do |format|
      if @app.save
              Severity: Minor
              Found in app/controllers/apps_controller.rb and 1 other location - About 1 hr to fix
              app/controllers/orgs_controller.rb on lines 52..61

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                def create
    @org = Org.new(org_params)

    respond_to do |format|
      if @org.save
              Severity: Minor
              Found in app/controllers/orgs_controller.rb and 1 other location - About 1 hr to fix
              app/controllers/apps_controller.rb on lines 110..119

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method update_edit_request has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def update_edit_request
      # Todo: send email. Right now the client never see's feedback if the edits are approved.
      @app_edit_request.approver = current_user
      if params[:approve]
        @app.description = (@app_edit_request.description.blank?) ? @app.features : @app_edit_request.description
              Severity: Minor
              Found in app/controllers/my_approval_requests_controller.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def update
        redirect_to new_my_project_edit_path and return if @app_edit_request.nil?
        unless update_to_edit_made(@app_edit_request)
            redirect_to edit_my_project_edit_path, alert: 'There were no updates to edits made.'
            return
              Severity: Minor
              Found in app/controllers/my_projects_controller.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def create
        redirect_to edit_my_project_edit_path(app_id: params[:app_id]) and return unless @app_edit_request.nil?
        @app_edit_request = AppEditRequest.new(
            app_id:       params[:app_id],
            description:  params[:description],
              Severity: Minor
              Found in app/controllers/my_projects_controller.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method mail_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def mail_to(name, email, subject, content, sender)
              Severity: Minor
              Found in app/mailers/form_mailer.rb - About 35 mins to fix

                Method send_form has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def send_form(name, email, url, iter, eng)
                Severity: Minor
                Found in app/mailers/form_mailer.rb - About 35 mins to fix

                  Method propose has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def propose(team, team_preferences)
      team_preferences.each do |app|
        puts "Team preferences: " + team_preferences.to_s
        puts "Team " + team + " proposing to App " + app
        # Check if the app is currently matched
                  Severity: Minor
                  Found in app/models/matching.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      status_map.each do |status, count|
      status_str = App.statuses.keys[status]
      if App.getAllVettingStatuses.include? status_str.to_sym
        @vetting_map[status_str] = count
        @total_vet += count
                  Severity: Minor
                  Found in app/controllers/apps_controller.rb and 1 other location - About 35 mins to fix
                  app/controllers/my_projects_controller.rb on lines 150..158

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 35.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method store has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def store
    @matching = Matching.find(params[:matching_id])
    @engagement = Engagement.find(params[:engagement_id])

    # Update last update users
                  Severity: Minor
                  Found in app/controllers/matching_controller.rb - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language