Sign upLogin

sabirvirtuoso/Kraken

View on GitHub
Star

Showing 48 of 48 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        AssertThrows(expression: try Kraken.inject(Service.self, withArguments: "some argument one", "some argument two", "some argument three")) { error in
            guard case let KrakenError.definitionNotFound(key) = error else {
                return false
            }
Severity: Major
Found in Example/Tests/KrakenTests.swift and 8 other locations - About 50 mins to fix
Example/Tests/DependencyScopeTests.swift on lines 433..447
Example/Tests/DependencyScopeTests.swift on lines 454..467
Example/Tests/DependencyScopeTests.swift on lines 474..487
Example/Tests/KrakenTests.swift on lines 264..274
Example/Tests/KrakenTests.swift on lines 282..292
Example/Tests/KrakenTests.swift on lines 300..310
Example/Tests/RuntimeArgumentsTests.swift on lines 248..258
Example/Tests/RuntimeArgumentsTests.swift on lines 270..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        AssertThrows(expression: try Kraken.inject(Service.self, withArguments: arg1)) { error in
            guard case let KrakenError.factoryNotFound(key) = error else {
                return false
            }
Severity: Major
Found in Example/Tests/RuntimeArgumentsTests.swift and 8 other locations - About 50 mins to fix
Example/Tests/DependencyScopeTests.swift on lines 433..447
Example/Tests/DependencyScopeTests.swift on lines 454..467
Example/Tests/DependencyScopeTests.swift on lines 474..487
Example/Tests/KrakenTests.swift on lines 264..274
Example/Tests/KrakenTests.swift on lines 282..292
Example/Tests/KrakenTests.swift on lines 300..310
Example/Tests/KrakenTests.swift on lines 318..328
Example/Tests/RuntimeArgumentsTests.swift on lines 270..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        AssertThrows(expression: try Kraken.register(Service.self, scope: .eagerSingleton) { (a1: Int) -> Injectable in

            return ServiceImpl1() as Service

        }) { error in
Severity: Major
Found in Example/Tests/DependencyScopeTests.swift and 8 other locations - About 50 mins to fix
Example/Tests/DependencyScopeTests.swift on lines 454..467
Example/Tests/DependencyScopeTests.swift on lines 474..487
Example/Tests/KrakenTests.swift on lines 264..274
Example/Tests/KrakenTests.swift on lines 282..292
Example/Tests/KrakenTests.swift on lines 300..310
Example/Tests/KrakenTests.swift on lines 318..328
Example/Tests/RuntimeArgumentsTests.swift on lines 248..258
Example/Tests/RuntimeArgumentsTests.swift on lines 270..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        AssertThrows(expression: try Kraken.inject(Service.self)) { error in
            guard case let KrakenError.definitionNotFound(key) = error else {
                return false
            }
Severity: Major
Found in Example/Tests/KrakenTests.swift and 8 other locations - About 50 mins to fix
Example/Tests/DependencyScopeTests.swift on lines 433..447
Example/Tests/DependencyScopeTests.swift on lines 454..467
Example/Tests/DependencyScopeTests.swift on lines 474..487
Example/Tests/KrakenTests.swift on lines 282..292
Example/Tests/KrakenTests.swift on lines 300..310
Example/Tests/KrakenTests.swift on lines 318..328
Example/Tests/RuntimeArgumentsTests.swift on lines 248..258
Example/Tests/RuntimeArgumentsTests.swift on lines 270..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        AssertThrows(expression: try Kraken.register(Service.self, scope: .eagerSingleton) { (a1: Int, a2: Int) -> Injectable in

            return ServiceImpl1() as Service
        }) { error in
            guard case let KrakenError.eagerSingletonNotAllowed(key) = error else {
Severity: Major
Found in Example/Tests/DependencyScopeTests.swift and 8 other locations - About 50 mins to fix
Example/Tests/DependencyScopeTests.swift on lines 433..447
Example/Tests/DependencyScopeTests.swift on lines 474..487
Example/Tests/KrakenTests.swift on lines 264..274
Example/Tests/KrakenTests.swift on lines 282..292
Example/Tests/KrakenTests.swift on lines 300..310
Example/Tests/KrakenTests.swift on lines 318..328
Example/Tests/RuntimeArgumentsTests.swift on lines 248..258
Example/Tests/RuntimeArgumentsTests.swift on lines 270..280

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try! Kraken.register(Service.self, tag: ServiceTypeNumber.VIP) { (a1: Int) -> Injectable in
            XCTAssertEqual(a1, arg1)

            return ServiceImp2() as Service
        }
Severity: Minor
Found in Example/Tests/RuntimeArgumentsTests.swift and 1 other location - About 50 mins to fix
Example/Tests/RuntimeArgumentsTests.swift on lines 115..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        try! Kraken.register(Service.self, tag: ServiceTypeNumber.Normal) { (a1: Int) -> Injectable in
            XCTAssertEqual(a1, arg1)

            return ServiceImp1() as Service
        }
Severity: Minor
Found in Example/Tests/RuntimeArgumentsTests.swift and 1 other location - About 50 mins to fix
Example/Tests/RuntimeArgumentsTests.swift on lines 121..125

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 58.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function registerFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    fileprivate static func registerFactory<F>(_ interface: Any, tag: DependencyTagConvertible?, scope: DependencyScope, factory: F, numberOfArguments: Int = 0, completionHandler: ((Injectable) -> ())? = nil) {
Severity: Minor
Found in Pod/Classes/RuntimeArguments.swift - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            try! Kraken.register(Service.self) { (a1: Int) -> Injectable in
            XCTAssertEqual(a1, arg1)

            return ServiceImpl1() as Service
        }
    Severity: Minor
    Found in Example/Tests/DependencyScopeTests.swift and 1 other location - About 45 mins to fix
    Example/Tests/RuntimeArgumentsTests.swift on lines 98..102

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            try! Kraken.register(Service.self) { (a1: Int) -> Injectable in
            XCTAssertEqual(a1, arg1)

            return ServiceImp1() as Service
        }
    Severity: Minor
    Found in Example/Tests/RuntimeArgumentsTests.swift and 1 other location - About 45 mins to fix
    Example/Tests/DependencyScopeTests.swift on lines 214..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            try! Kraken.register(Service.self, scope: .singleton) { (a1: Int, a2: Int) -> Injectable in

            return ServiceImpl1() as Service
        }
    Severity: Minor
    Found in Example/Tests/DependencyScopeTests.swift and 1 other location - About 45 mins to fix
    Example/Tests/DependencyScopeTests.swift on lines 454..457

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    extension DependencyTagConvertible where Self: RawRepresentable, Self.RawValue == Int {
    public var dependencyTag: Tag {
        return .Int(rawValue)
    }
}
    Severity: Minor
    Found in Pod/Classes/DependencyTag.swift and 1 other location - About 40 mins to fix
    Pod/Classes/DependencyTag.swift on lines 101..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    extension DependencyTagConvertible where Self: RawRepresentable, Self.RawValue == String {
    public var dependencyTag: Tag {
        return .String(rawValue)
    }
}
    Severity: Minor
    Found in Pod/Classes/DependencyTag.swift and 1 other location - About 40 mins to fix
    Pod/Classes/DependencyTag.swift on lines 92..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function inject has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    public func inject<Arg1, Arg2, Arg3, T>(_ typeToInject: T.Type, tag: DependencyTagConvertible? = nil, withArguments arg1: Arg1, _ arg2: Arg2, _ arg3: Arg3) -> T where T: Any {
    Severity: Minor
    Found in Pod/Classes/RuntimeArguments.swift - About 35 mins to fix

      Function register has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static func register(_ interface: Any, tag: DependencyTagConvertible? = nil, scope: DependencyScope = .prototype, factory: () -> Injectable?, completionHandler: ((_ resolvedInstance: Injectable) -> ())? = nil) {
      Severity: Minor
      Found in Pod/Classes/RuntimeArguments.swift - About 35 mins to fix

        Function inject has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static func inject<Arg1, Arg2, Arg3>(_ typeToInject: Any, tag: DependencyTagConvertible? = nil, withArguments arg1: Arg1, _ arg2: Arg2, _ arg3: Arg3) throws -> Injectable? {
        Severity: Minor
        Found in Pod/Classes/RuntimeArguments.swift - About 35 mins to fix

          Function AssertThrows has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func AssertThrows<T>(_ file: StaticString = #file, line: UInt = #line, expression: @autoclosure () throws -> T, checkError: (Error) -> Bool, _ message: String) {
          Severity: Minor
          Found in Example/Tests/Utils.swift - About 35 mins to fix

            Function register has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static func register(_ interface: Any, tag: DependencyTagConvertible? = nil, implementationType: Injectable.Type,  scope: DependencyScope = .prototype, completionHandler: ((_ resolvedInstance: Injectable) -> ())? = nil) {
            Severity: Minor
            Found in Pod/Classes/Kraken.swift - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      try! Kraken.register(Service.self, scope: .singleton) { (a1: Int) -> Injectable in

            return ServiceImpl1() as Service
        }
              Severity: Minor
              Found in Example/Tests/DependencyScopeTests.swift and 1 other location - About 35 mins to fix
              Example/Tests/DependencyScopeTests.swift on lines 433..437

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Enum case names should be lowerCamelCase
              Open

                  case Int(IntegerLiteralType)
              Severity: Minor
              Found in Pod/Classes/DependencyTag.swift by tailor

              lower-camel-case

              method and var names should follow lowerCamelCase naming convention: first letter of the entire word is lowercase, but subsequent first letters are uppercase.

              Method and selector names

              Preferred

              func someMethod() {
    // method definition goes here
}

              Not Preferred

              func some-method() {
    // method definition goes here
}

              Variable names

              Preferred

              var someVariable = someValue

              Not Preferred

              var Some_Var1able = someValue
              Severity
              Category
              Status
              Source
              Language