Sign upLogin

sahat/satellizer

View on GitHub
Star
examples/server/php/app/Http/Controllers/AuthController.php

Summary

Maintainability
F
1 wk
Test Coverage

File AuthController.php has 445 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace App\Http\Controllers;

use Hash;
use Config;
use Validator;
Severity: Minor
Found in examples/server/php/app/Http/Controllers/AuthController.php - About 6 hrs to fix

    Method twitter has 83 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function twitter(Request $request)
    {
        $stack = GuzzleHttp\HandlerStack::create();

        // Part 1 of 2: Initial request from Satellizer.
    Severity: Major
    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 3 hrs to fix

      Method facebook has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function facebook(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
      Severity: Minor
      Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

        Method linkedin has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function linkedin(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
        Severity: Minor
        Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

          Method foursquare has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function foursquare(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
          Severity: Minor
          Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

            Method google has 46 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function google(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
            Severity: Minor
            Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

              Method github has 45 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function github(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
              Severity: Minor
              Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

                Method instagram has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function instagram(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                Severity: Minor
                Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

                  Function twitter has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function twitter(Request $request)
    {
        $stack = GuzzleHttp\HandlerStack::create();

        // Part 1 of 2: Initial request from Satellizer.
                  Severity: Minor
                  Found in examples/server/php/app/Http/Controllers/AuthController.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                                  return response()->json(['token' => $this->createToken($user)]);
                  Severity: Major
                  Found in examples/server/php/app/Http/Controllers/AuthController.php - About 30 mins to fix

                    Function instagram has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function instagram(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function github has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function github(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function linkedin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function linkedin(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function google has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function google(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function foursquare has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function foursquare(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function facebook has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function facebook(Request $request)
    {
        $client = new GuzzleHttp\Client();

        $params = [
                    Severity: Minor
                    Found in examples/server/php/app/Http/Controllers/AuthController.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($request->header('Authorization'))
        {
            $user = User::where('foursquare', '=', $profile['id']);
            if ($user->first())
            {
                    Severity: Major
                    Found in examples/server/php/app/Http/Controllers/AuthController.php and 1 other location - About 1 day to fix
                    examples/server/php/app/Http/Controllers/AuthController.php on lines 267..302

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 361.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($request->header('Authorization'))
        {
            $user = User::where('linkedin', '=', $profile['id']);

            if ($user->first())
                    Severity: Major
                    Found in examples/server/php/app/Http/Controllers/AuthController.php and 1 other location - About 1 day to fix
                    examples/server/php/app/Http/Controllers/AuthController.php on lines 455..489

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 361.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if ($request->header('Authorization'))
            {
                $user = User::where('twitter', '=', $profile['id']);
                if ($user->first())
                {
                    Severity: Major
                    Found in examples/server/php/app/Http/Controllers/AuthController.php and 1 other location - About 1 day to fix
                    examples/server/php/app/Http/Controllers/AuthController.php on lines 581..616

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 337.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ($request->header('Authorization'))
        {
            $user = User::where('github', '=', $profile['id']);

            if ($user->first())
                    Severity: Major
                    Found in examples/server/php/app/Http/Controllers/AuthController.php and 1 other location - About 1 day to fix
                    examples/server/php/app/Http/Controllers/AuthController.php on lines 385..419

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 337.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status