sahin/status-page

View on GitHub

Showing 9 of 9 total issues

Function parseStatusCurrent has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export function parseStatusCurrent($, serviceCurrent) {
  const service = serviceCurrent;

  service.status.description = $('.page-status span.status').text().trim();

Severity: Minor
Found in src/lib/Parsers/StatusPage.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      } else if (text.indexOf('impact-minor') > -1) {
        service.status.indicator = 'Minor';
      } else if (text.indexOf('impact-none') > -1) {
        service.status.indicator = 'Non impact';
      }
Severity: Major
Found in src/lib/Parsers/StatusPage.js and 1 other location - About 1 hr to fix
src/lib/Parsers/StatusPage.js on lines 16..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if (desc.indexOf('status-minor') > -1) {
        service.status.indicator = 'Minor';
      } else if (desc.indexOf('status-major') > -1) {
        service.status.indicator = 'Major';
      }
Severity: Major
Found in src/lib/Parsers/StatusPage.js and 1 other location - About 1 hr to fix
src/lib/Parsers/StatusPage.js on lines 29..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function parseStatusCurrent has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function parseStatusCurrent($, serviceCurrent) {
  const service = serviceCurrent;

  service.status.description = $('.page-status span.status').text().trim();

Severity: Minor
Found in src/lib/Parsers/StatusPage.js - About 1 hr to fix

    Function editReadmeForService has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function editReadmeForService(service) {
      const github = new Github(config.github);
    
      const repo = github.getRepo('sahin', 'status-page');
    
    
    Severity: Minor
    Found in src/lib/Service.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        return new Promise((resolve) => {
          request(url, (error, response, body) => {
            if (!error && response.statusCode === 200) {
              resolve(body);
            }
      Severity: Major
      Found in src/lib/Common/Request.js and 1 other location - About 1 hr to fix
      src/lib/Common/Request.js on lines 6..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        return new Promise((resolve) => {
          request(url, (error, response, body) => {
            if (!error && response.statusCode === 200) {
              resolve(body);
            }
      Severity: Major
      Found in src/lib/Common/Request.js and 1 other location - About 1 hr to fix
      src/lib/Common/Request.js on lines 16..22

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          const options = {
            author: { name: 'Sahin Boydas', email: 'sahin@movielala.com' },
            committer: { name: 'Sahin Boydas', email: 'sahin@movielala.com' },
            encode: true, // Whether to base64 encode the file. (default: true)
          };
      Severity: Minor
      Found in src/lib/GithubApi.js and 1 other location - About 35 mins to fix
      src/lib/Service.js on lines 16..20

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const options = {
          author: { name: 'Sahin Boydas', email: 'sahinboydas@gmail.com' },
          committer: { name: 'Sahin Boydas', email: 'sahinboydas@gmail.com' },
          encode: true, // Whether to base64 encode the file. (default: true)
        };
      Severity: Minor
      Found in src/lib/Service.js and 1 other location - About 35 mins to fix
      src/lib/GithubApi.js on lines 12..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language