Sign upLogin

sahitono/geosardine

View on GitHub
Star
geosardine/_geosardine.py

Summary

Maintainability
B
4 hrs
Test Coverage

File _geosardine.py has 288 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import warnings
from collections import OrderedDict
from math import ceil, floor
from typing import Callable, Dict, Generator, Iterable, List, Tuple, Union
Severity: Minor
Found in geosardine/_geosardine.py - About 2 hrs to fix

    Cyclomatic complexity is too high in function spatial_join. (6)
    Open

    def spatial_join(
    target: fiona.Collection, join: fiona.Collection
) -> Tuple[List[Dict], Dict]:
    """
    Join attribute from 2 vector by location.
    Severity: Minor
    Found in geosardine/_geosardine.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function drape2raster has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def drape2raster(
    Severity: Minor
    Found in geosardine/_geosardine.py - About 35 mins to fix

      Function drape_coordinates has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def drape_coordinates(
      Severity: Minor
      Found in geosardine/_geosardine.py - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status