Sign upLogin

sahitono/geosardine

View on GitHub
Star
geosardine/_utility.py

Summary

Maintainability
C
1 day
Test Coverage

File _utility.py has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import math
from functools import singledispatch
from pathlib import Path
from typing import List, Optional, Tuple, Union
Severity: Minor
Found in geosardine/_utility.py - About 4 hrs to fix

    Cyclomatic complexity is too high in function save_raster. (11)
    Open

    def save_raster(
    file_name: Union[str, Path],
    value_array: np.ndarray,
    crs: Union[CRS, int],
    coordinate_array: Optional[np.ndarray] = None,
    Severity: Minor
    Found in geosardine/_utility.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function save_raster has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def save_raster(
    file_name: Union[str, Path],
    value_array: np.ndarray,
    crs: Union[CRS, int],
    coordinate_array: Optional[np.ndarray] = None,
    Severity: Minor
    Found in geosardine/_utility.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function save_raster has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def save_raster(
    Severity: Major
    Found in geosardine/_utility.py - About 50 mins to fix

      Function _vincenty_distance has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def _vincenty_distance(
    long_lat1: np.ndarray,
    long_lat2: np.ndarray,
    semi_major: float = 6378137.0,
    semi_minor: float = 6356752.314245179,
      Severity: Minor
      Found in geosardine/_utility.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _vincenty_distance_dispatch has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _vincenty_distance_dispatch(
      Severity: Minor
      Found in geosardine/_utility.py - About 45 mins to fix

        Function _harvesine_distance has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _harvesine_distance(
        Severity: Minor
        Found in geosardine/_utility.py - About 35 mins to fix

          Function __harvesine_distance has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def __harvesine_distance(
          Severity: Minor
          Found in geosardine/_utility.py - About 35 mins to fix

            Function _vincenty_distance has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _vincenty_distance(
            Severity: Minor
            Found in geosardine/_utility.py - About 35 mins to fix

              Function __harvesine_distance has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def __harvesine_distance(
              Severity: Minor
              Found in geosardine/_utility.py - About 35 mins to fix

                Function _harvesine_distance_dispatch has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def _harvesine_distance_dispatch(
                Severity: Minor
                Found in geosardine/_utility.py - About 35 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status