Sign upLogin

sahitono/geosardine

View on GitHub
Star
geosardine/interpolate/idw.py

Summary

Maintainability
C
1 day
Test Coverage

File idw.py has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import warnings
from functools import singledispatch
from pathlib import Path
from typing import Callable, List, Optional, Tuple, Union
Severity: Minor
Found in geosardine/interpolate/idw.py - About 2 hrs to fix

    Cyclomatic complexity is too high in function _idw_file. (6)
    Open

    @idw.register
def _idw_file(
    file_name: str,
    spatial_res: Tuple[float, float],
    epsg: Optional[int] = None,
    Severity: Minor
    Found in geosardine/interpolate/idw.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function _idw_array has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _idw_array(
    Severity: Major
    Found in geosardine/interpolate/idw.py - About 1 hr to fix

      Function idw has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def idw(
      Severity: Major
      Found in geosardine/interpolate/idw.py - About 1 hr to fix

        Function _idw has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _idw(
        Severity: Major
        Found in geosardine/interpolate/idw.py - About 1 hr to fix

          Function _idw_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          def _idw_file(
    file_name: str,
    spatial_res: Tuple[float, float],
    epsg: Optional[int] = None,
    column_name: Optional[str] = None,
          Severity: Minor
          Found in geosardine/interpolate/idw.py - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _idw_file has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _idw_file(
          Severity: Major
          Found in geosardine/interpolate/idw.py - About 1 hr to fix

            Function _idw_file_path has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _idw_file_path(
            Severity: Major
            Found in geosardine/interpolate/idw.py - About 1 hr to fix

              Function idw_single has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def idw_single(
              Severity: Major
              Found in geosardine/interpolate/idw.py - About 50 mins to fix

                Function _idw_array has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def _idw_array(
    points: np.ndarray,
    value: np.ndarray,
    spatial_res: Tuple[float, float],
    epsg: int = 4326,
                Severity: Minor
                Found in geosardine/interpolate/idw.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status