saiqulhaq/firebase_dynamic_link

View on GitHub

Showing 47 of 50 total issues

FirebaseDynamicLink::Client#shorten_link has the variable name 'e'
Open

    rescue Faraday::ConnectionFailed, Faraday::TimeoutError => e
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by reek

An Uncommunicative Variable Name is a variable name that doesn't communicate its intent well enough.

Poor names make it hard for the reader to build a mental picture of what's going on in the code. They can also be mis-interpreted; and they hurt the flow of reading, because the reader must slow down to interpret the names.

Line is too long. [101/80]
Open

  spec.description   = 'Create deep link for web and mobile app using Firebase Dynamic Links service'
Severity: Minor
Found in firebase_dynamic_link.gemspec by rubocop

Line is too long. [89/80]
Open

    # @see FirebaseDynamicLink::LinkRenderer#render LinkRenderer#render for returned Hash
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [85/80]
Open

      connection.open_timeout = options[:open_timeout] if options.key?(:open_timeout)
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [97/80]
Open

                                                                  'Dynamic link domain is empty')
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [87/80]
Open

      params = CaseTransform2.camel_lower(long_dynamic_link: build_link(link, options),
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [97/80]
Open

                                                                  'Dynamic link domain is empty')
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [89/80]
Open

                                            option: suffix_option || config.suffix_option
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [85/80]
Open

      connection.open_timeout = options[:open_timeout] if options.key?(:open_timeout)
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [82/80]
Open

      reason = response.reason_phrase.to_s if response.respond_to?(:reason_phrase)

Line is too long. [93/80]
Open

    #   * :open_timeout [Integer] optional, default is FirebaseDynamicLink.config.open_timout
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [107/80]
Open

    #   * :dynamic_link_domain [String] optional, default is FirebaseDynamicLink.config.dynamic_link_domain
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [89/80]
Open

                                            option: suffix_option || config.suffix_option
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [81/80]
Open

    setting(:suffix_option, default: 'UNGUESSABLE', constructor: lambda { |value|
Severity: Minor
Found in lib/firebase_dynamic_link.rb by rubocop

Line is too long. [86/80]
Open

      raise FirebaseDynamicLink::ConnectionError, [reason, message].compact.join(': ')

Line is too long. [112/80]
Open

      params = CaseTransform2.camel_lower(dynamic_link_info: params.merge(domainUriPrefix: dynamic_link_domain),
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [101/80]
Open

      dynamic_link_domain ||= config.dynamic_link_domain || raise(FirebaseDynamicLink::InvalidConfig,
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop

Line is too long. [94/80]
Open

  #   @raise [FirebaseDynamicLink::InvalidConfig] if value is not one of SHORT and UNGUESSABLE
Severity: Minor
Found in lib/firebase_dynamic_link.rb by rubocop

Missing top-level module documentation comment.
Open

module FirebaseDynamicLink
Severity: Minor
Found in lib/firebase_dynamic_link.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [95/80]
Open

    #   * :suffix_option [String] optional, default is FirebaseDynamicLink.config.suffix_option
Severity: Minor
Found in lib/firebase_dynamic_link/client.rb by rubocop
Severity
Category
Status
Source
Language