Sign upLogin

saiqulhaq/firebase_dynamic_link

View on GitHub
Star
lib/firebase_dynamic_link/connection.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

FirebaseDynamicLink::Connection#initialize calls 'client.options' 2 times
Open

      client.options.timeout = FirebaseDynamicLink.config.timeout
      client.options.open_timeout = FirebaseDynamicLink.config.open_timeout
Severity: Minor
Found in lib/firebase_dynamic_link/connection.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

FirebaseDynamicLink::Connection#initialize calls 'FirebaseDynamicLink.config' 2 times
Open

      client.options.timeout = FirebaseDynamicLink.config.timeout
      client.options.open_timeout = FirebaseDynamicLink.config.open_timeout
Severity: Minor
Found in lib/firebase_dynamic_link/connection.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Line is too long. [90/80]
Open

                                        headers: { 'Content-Type' => 'application/json' })
Severity: Minor
Found in lib/firebase_dynamic_link/connection.rb by rubocop

There are no issues that match your filters.

Category
Status