Sign upLogin

sakama/vagrant-niftycloud

View on GitHub
Star

Showing 13 of 13 total issues

Method call has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def call(env)
          # Initialize metrics if they haven't been
          env[:metrics] ||= {}
          # Get the zone we're going to booting up in
          zone = env[:machine].provider_config.zone
Severity: Major
Found in lib/vagrant-niftycloud/action/run_instance.rb - About 2 hrs to fix

    Method call has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def call(env)
          # Initialize metrics if they haven't been
          env[:metrics] ||= {}
          # Get the zone we're going to booting up in
          zone = env[:machine].provider_config.zone
    Severity: Minor
    Found in lib/vagrant-niftycloud/action/run_instance.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def call(env)
          @app.call(env)

          ssh_info = env[:machine].ssh_info
          env[:machine].config.vm.synced_folders.each do |id, data|
    Severity: Minor
    Found in lib/vagrant-niftycloud/action/sync_folders.rb - About 1 hr to fix

      Method finalize! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def finalize!
        # Try to get access keys from standard NiftyCloud environment variables; they
        # will default to nil if the environment variables are not present.
        @access_key_id     = ENV['NIFTY_CLOUD_ACCESS_KEY'] if @access_key_id     == UNSET_VALUE
        @secret_access_key = ENV['NIFTY_CLOUD_SECRET_KEY'] if @secret_access_key == UNSET_VALUE
      Severity: Minor
      Found in lib/vagrant-niftycloud/config.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              def call(env)
          @app.call(env)

          ssh_info = env[:machine].ssh_info
          env[:machine].config.vm.synced_folders.each do |id, data|
      Severity: Minor
      Found in lib/vagrant-niftycloud/action/sync_folders.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_state has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def read_state(niftycloud, machine)
          return :not_created if machine.id.nil?

          # Find the machine
          # 例外の定義は以下参照
      Severity: Minor
      Found in lib/vagrant-niftycloud/action/read_state.rb - About 1 hr to fix

        Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def validate(machine)
        errors = _detected_errors

        errors << I18n.t("vagrant_niftycloud.config.zone_required") if @zone.nil?
        Severity: Minor
        Found in lib/vagrant-niftycloud/config.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              def self.action_suspend
        Vagrant::Action::Builder.new.tap do |b|
          b.use Call, IsCreated do |env, b2|
            if env[:result]
              b2.use ConfigValidate
        Severity: Minor
        Found in lib/vagrant-niftycloud/action.rb and 2 other locations - About 35 mins to fix
        lib/vagrant-niftycloud/action.rb on lines 129..139
        lib/vagrant-niftycloud/action.rb on lines 145..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              def self.action_resume
        Vagrant::Action::Builder.new.tap do |b|
          b.use Call, IsCreated do |env, b2|
            if env[:result]
              b2.use ConfigValidate
        Severity: Minor
        Found in lib/vagrant-niftycloud/action.rb and 2 other locations - About 35 mins to fix
        lib/vagrant-niftycloud/action.rb on lines 113..123
        lib/vagrant-niftycloud/action.rb on lines 129..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              def self.action_halt
        Vagrant::Action::Builder.new.tap do |b|
          b.use Call, IsCreated do |env, b2|
            if env[:result]
              b2.use ConfigValidate
        Severity: Minor
        Found in lib/vagrant-niftycloud/action.rb and 2 other locations - About 35 mins to fix
        lib/vagrant-niftycloud/action.rb on lines 113..123
        lib/vagrant-niftycloud/action.rb on lines 145..155

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def self.action_ssh_run
        Vagrant::Action::Builder.new.tap do |b|
          b.use ConfigValidate
          b.use Call, IsCreated do |env, b2|
            if !env[:result]
        Severity: Minor
        Found in lib/vagrant-niftycloud/action.rb and 1 other location - About 35 mins to fix
        lib/vagrant-niftycloud/action.rb on lines 65..74

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def self.action_ssh
        Vagrant::Action::Builder.new.tap do |b|
          b.use ConfigValidate
          b.use Call, IsCreated do |env, b2|
            if !env[:result]
        Severity: Minor
        Found in lib/vagrant-niftycloud/action.rb and 1 other location - About 35 mins to fix
        lib/vagrant-niftycloud/action.rb on lines 79..88

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 34.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method wait_while_status_is has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def wait_while_status_is(env, status)
          server = get(env[:machine])
          if status =~ /^not_/
            status.sub!("not_", "")
            while server.instanceState.name != status
        Severity: Minor
        Found in lib/vagrant-niftycloud/servers/servers.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language