sakama/vagrant-niftycloud

View on GitHub

Showing 8 of 13 total issues

Method call has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def call(env)
          # Initialize metrics if they haven't been
          env[:metrics] ||= {}
          # Get the zone we're going to booting up in
          zone = env[:machine].provider_config.zone
Severity: Major
Found in lib/vagrant-niftycloud/action/run_instance.rb - About 2 hrs to fix

    Method call has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

            def call(env)
              # Initialize metrics if they haven't been
              env[:metrics] ||= {}
              # Get the zone we're going to booting up in
              zone = env[:machine].provider_config.zone
    Severity: Minor
    Found in lib/vagrant-niftycloud/action/run_instance.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            def call(env)
              @app.call(env)
    
              ssh_info = env[:machine].ssh_info
              env[:machine].config.vm.synced_folders.each do |id, data|
    Severity: Minor
    Found in lib/vagrant-niftycloud/action/sync_folders.rb - About 1 hr to fix

      Method finalize! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def finalize!
              # Try to get access keys from standard NiftyCloud environment variables; they
              # will default to nil if the environment variables are not present.
              @access_key_id     = ENV['NIFTY_CLOUD_ACCESS_KEY'] if @access_key_id     == UNSET_VALUE
              @secret_access_key = ENV['NIFTY_CLOUD_SECRET_KEY'] if @secret_access_key == UNSET_VALUE
      Severity: Minor
      Found in lib/vagrant-niftycloud/config.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

              def call(env)
                @app.call(env)
      
                ssh_info = env[:machine].ssh_info
                env[:machine].config.vm.synced_folders.each do |id, data|
      Severity: Minor
      Found in lib/vagrant-niftycloud/action/sync_folders.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_state has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def read_state(niftycloud, machine)
                return :not_created if machine.id.nil?
      
                # Find the machine
                # 例外の定義は以下参照
      Severity: Minor
      Found in lib/vagrant-niftycloud/action/read_state.rb - About 1 hr to fix

        Method validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def validate(machine)
                errors = _detected_errors
        
                errors << I18n.t("vagrant_niftycloud.config.zone_required") if @zone.nil?
        
        
        Severity: Minor
        Found in lib/vagrant-niftycloud/config.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method wait_while_status_is has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def wait_while_status_is(env, status)
                  server = get(env[:machine])
                  if status =~ /^not_/
                    status.sub!("not_", "")
                    while server.instanceState.name != status
        Severity: Minor
        Found in lib/vagrant-niftycloud/servers/servers.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language