saltstack/salt

View on GitHub

Showing 17,495 of 17,590 total issues

File minion.py has 2953 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Routines to set up a minion
'''
# Import python libs
Severity: Major
Found in salt/minion.py - About 1 wk to fix

    File git.py has 2907 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
    '''
    States to manage git repositories and git configuration
    
    .. important::
    Severity: Major
    Found in salt/states/git.py - About 1 wk to fix

      File __init__.py has 2868 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
      '''
      All salt configuration loading and defaults should be in this module
      '''
      
      
      Severity: Major
      Found in salt/config/__init__.py - About 1 wk to fix

        Function vm_present has a Cognitive Complexity of 387 (exceeds 5 allowed). Consider refactoring.
        Open

        def vm_present(name, vmconfig, config=None):
            '''
            Ensure vm is present on the computenode
        
            name : string
        Severity: Minor
        Found in salt/states/smartos.py - About 1 wk to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File cloud.py has 2764 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
        '''
        Utility functions for salt.cloud
        '''
        
        
        Severity: Major
        Found in salt/utils/cloud.py - About 1 wk to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Severity: Major
          Found in salt/wheel/pillar_roots.py and 1 other location - About 1 wk to fix
          salt/wheel/file_roots.py on lines 0..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 774.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Severity: Major
          Found in salt/wheel/file_roots.py and 1 other location - About 1 wk to fix
          salt/wheel/pillar_roots.py on lines 0..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 774.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File parsers.py has 2735 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
          '''
              :codeauthor: Pedro Algarvio (pedro@algarvio.me)
          
          
          
          Severity: Major
          Found in salt/utils/parsers.py - About 1 wk to fix

            File pkg.py has 2699 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
            '''
            Installation of packages using OS package managers such as yum or apt-get
            =========================================================================
            
            
            Severity: Major
            Found in salt/states/pkg.py - About 1 wk to fix

              File gitfs.py has 2672 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
              '''
              Classes which provide the shared base for GitFS, git_pillar, and winrepo
              '''
              
              
              Severity: Major
              Found in salt/utils/gitfs.py - About 1 wk to fix

                File lxd.py has 2670 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # -*- coding: utf-8 -*-
                '''
                Module for managing the LXD daemon and its containers.
                
                .. versionadded:: 2019.2.0
                Severity: Major
                Found in salt/modules/lxd.py - About 1 wk to fix

                  Function mounted has a Cognitive Complexity of 363 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def mounted(name,
                              device,
                              fstype,
                              mkmnt=False,
                              opts='defaults',
                  Severity: Minor
                  Found in salt/states/mount.py - About 1 wk to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File msazure.py has 2587 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
                  '''
                  Azure Cloud Module
                  ==================
                  
                  
                  Severity: Major
                  Found in salt/cloud/clouds/msazure.py - About 1 wk to fix

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def _dashboard_diff(_new_dashboard, _old_dashboard):
                        '''Return a dictionary of changes between dashboards.'''
                        diff = {}
                    
                        # Dashboard diff
                    Severity: Major
                    Found in salt/states/grafana_dashboard.py and 1 other location - About 1 wk to fix
                    salt/states/grafana4_dashboard.py on lines 440..508

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 706.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def _dashboard_diff(_new_dashboard, _old_dashboard):
                        '''Return a dictionary of changes between dashboards.'''
                        diff = {}
                    
                        # Dashboard diff
                    Severity: Major
                    Found in salt/states/grafana4_dashboard.py and 1 other location - About 1 wk to fix
                    salt/states/grafana_dashboard.py on lines 469..537

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 706.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    File bigip.py has 2509 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
                    '''
                    A state module designed to enforce load-balancing configurations for F5 Big-IP entities.
                        :maturity:      develop
                        :platform:      f5_bigip_11.6
                    Severity: Major
                    Found in salt/states/bigip.py - About 1 wk to fix

                      File yumpkg.py has 2501 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # -*- coding: utf-8 -*-
                      '''
                      Support for YUM/DNF
                      
                      .. important::
                      Severity: Major
                      Found in salt/modules/yumpkg.py - About 1 wk to fix

                        Function _writeAdminTemplateRegPolFile has a Cognitive Complexity of 335 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def _writeAdminTemplateRegPolFile(admtemplate_data,
                                                          adml_language='en-US',
                                                          registry_class='Machine'):
                            r'''
                            helper function to prep/write adm template data to the Registry.pol file
                        Severity: Minor
                        Found in salt/modules/win_lgpo.py - About 6 days to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function os_data has a Cognitive Complexity of 317 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def os_data():
                            '''
                            Return grains pertaining to the operating system
                            '''
                            grains = {
                        Severity: Minor
                        Found in salt/grains/core.py - About 6 days to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File boto_vpc.py has 2343 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # -*- coding: utf-8 -*-
                        '''
                        Connection module for Amazon VPC
                        
                        .. versionadded:: 2014.7.0
                        Severity: Major
                        Found in salt/modules/boto_vpc.py - About 6 days to fix
                          Severity
                          Category
                          Status
                          Source
                          Language