Sign upLogin

saltstack/salt

View on GitHub
Star
salt/cloud/clouds/dimensiondata.py

Summary

Maintainability
F
5 days
Test Coverage

File dimensiondata.py has 485 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Dimension Data Cloud Module
===========================
Severity: Minor
Found in salt/cloud/clouds/dimensiondata.py - About 7 hrs to fix

    Function _query_node_data has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    def _query_node_data(vm_, data):
    running = False
    try:
        node = show_instance(vm_['name'], 'action')  # pylint: disable=not-callable
        running = (node['state'] == NodeState.RUNNING)
    Severity: Minor
    Found in salt/cloud/clouds/dimensiondata.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _to_event_data has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def _to_event_data(obj):
    '''
    Convert the specified object into a form that can be serialised by msgpack as event data.

    :param obj: The object to convert.
    Severity: Minor
    Found in salt/cloud/clouds/dimensiondata.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single VM from a data dict
    '''
    try:
    Severity: Minor
    Found in salt/cloud/clouds/dimensiondata.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create_lb has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def create_lb(kwargs=None, call=None):
    r'''
    Create a load-balancer configuration.
    CLI Example:
    Severity: Minor
    Found in salt/cloud/clouds/dimensiondata.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single VM from a data dict
    '''
    try:
    Severity: Minor
    Found in salt/cloud/clouds/dimensiondata.py - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return [_to_event_data(item) for item in obj]
      Severity: Major
      Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return event_data
        Severity: Major
        Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return obj.name
          Severity: Major
          Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return data
            Severity: Major
            Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return obj
              Severity: Major
              Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return obj
                Severity: Major
                Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return obj
                  Severity: Major
                  Found in salt/cloud/clouds/dimensiondata.py - About 30 mins to fix

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                    def preferred_ip(vm_, ips):
    '''
    Return the preferred Internet protocol. Either 'ipv4' (default) or 'ipv6'.
    '''
    proto = config.get_cloud_config_value(
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 2 other locations - About 4 hrs to fix
                    salt/cloud/clouds/nova.py on lines 420..438
                    salt/cloud/clouds/openstack.py on lines 292..309

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 84.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 38 locations. Consider refactoring.
                    Open

                        __utils__['cloud.fire_event'](
        'event',
        'created instance',
        'salt/cloud/{0}/created'.format(vm_['name']),
        args=__utils__['cloud.filter_event']('created', vm_, ['name', 'profile', 'provider', 'driver']),
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 37 other locations - About 2 hrs to fix
                    salt/cloud/clouds/aliyun.py on lines 625..631
                    salt/cloud/clouds/aliyun.py on lines 732..738
                    salt/cloud/clouds/azurearm.py on lines 1349..1359
                    salt/cloud/clouds/azurearm.py on lines 1398..1406
                    salt/cloud/clouds/azurearm.py on lines 1480..1489
                    salt/cloud/clouds/digitalocean.py on lines 287..293
                    salt/cloud/clouds/digitalocean.py on lines 537..543
                    salt/cloud/clouds/dimensiondata.py on lines 207..213
                    salt/cloud/clouds/ec2.py on lines 2579..2585
                    salt/cloud/clouds/gce.py on lines 2461..2467
                    salt/cloud/clouds/gce.py on lines 2551..2557
                    salt/cloud/clouds/gce.py on lines 2635..2641
                    salt/cloud/clouds/gogrid.py on lines 96..102
                    salt/cloud/clouds/gogrid.py on lines 180..186
                    salt/cloud/clouds/joyent.py on lines 274..280
                    salt/cloud/clouds/joyent.py on lines 325..331
                    salt/cloud/clouds/lxc.py on lines 440..446
                    salt/cloud/clouds/lxc.py on lines 460..466
                    salt/cloud/clouds/lxc.py on lines 488..494
                    salt/cloud/clouds/msazure.py on lines 429..435
                    salt/cloud/clouds/msazure.py on lines 683..689
                    salt/cloud/clouds/nova.py on lines 961..967
                    salt/cloud/clouds/opennebula.py on lines 1006..1012
                    salt/cloud/clouds/openstack.py on lines 684..690
                    salt/cloud/clouds/packet.py on lines 347..353
                    salt/cloud/clouds/parallels.py on lines 287..293
                    salt/cloud/clouds/parallels.py on lines 356..362
                    salt/cloud/clouds/proxmox.py on lines 578..585
                    salt/cloud/clouds/qingcloud.py on lines 668..674
                    salt/cloud/clouds/qingcloud.py on lines 738..744
                    salt/cloud/clouds/scaleway.py on lines 200..206
                    salt/cloud/clouds/scaleway.py on lines 304..310
                    salt/cloud/clouds/virtualbox.py on lines 176..182
                    salt/cloud/clouds/vmware.py on lines 2543..2549
                    salt/cloud/clouds/vmware.py on lines 3072..3078
                    salt/cloud/clouds/vultrpy.py on lines 292..298
                    salt/cloud/clouds/vultrpy.py on lines 465..471

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 38 locations. Consider refactoring.
                    Open

                        __utils__['cloud.fire_event'](
        'event',
        'starting create',
        'salt/cloud/{0}/creating'.format(vm_['name']),
        args=__utils__['cloud.filter_event']('creating', vm_, ['name', 'profile', 'provider', 'driver']),
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 37 other locations - About 2 hrs to fix
                    salt/cloud/clouds/aliyun.py on lines 625..631
                    salt/cloud/clouds/aliyun.py on lines 732..738
                    salt/cloud/clouds/azurearm.py on lines 1349..1359
                    salt/cloud/clouds/azurearm.py on lines 1398..1406
                    salt/cloud/clouds/azurearm.py on lines 1480..1489
                    salt/cloud/clouds/digitalocean.py on lines 287..293
                    salt/cloud/clouds/digitalocean.py on lines 537..543
                    salt/cloud/clouds/dimensiondata.py on lines 337..343
                    salt/cloud/clouds/ec2.py on lines 2579..2585
                    salt/cloud/clouds/gce.py on lines 2461..2467
                    salt/cloud/clouds/gce.py on lines 2551..2557
                    salt/cloud/clouds/gce.py on lines 2635..2641
                    salt/cloud/clouds/gogrid.py on lines 96..102
                    salt/cloud/clouds/gogrid.py on lines 180..186
                    salt/cloud/clouds/joyent.py on lines 274..280
                    salt/cloud/clouds/joyent.py on lines 325..331
                    salt/cloud/clouds/lxc.py on lines 440..446
                    salt/cloud/clouds/lxc.py on lines 460..466
                    salt/cloud/clouds/lxc.py on lines 488..494
                    salt/cloud/clouds/msazure.py on lines 429..435
                    salt/cloud/clouds/msazure.py on lines 683..689
                    salt/cloud/clouds/nova.py on lines 961..967
                    salt/cloud/clouds/opennebula.py on lines 1006..1012
                    salt/cloud/clouds/openstack.py on lines 684..690
                    salt/cloud/clouds/packet.py on lines 347..353
                    salt/cloud/clouds/parallels.py on lines 287..293
                    salt/cloud/clouds/parallels.py on lines 356..362
                    salt/cloud/clouds/proxmox.py on lines 578..585
                    salt/cloud/clouds/qingcloud.py on lines 668..674
                    salt/cloud/clouds/qingcloud.py on lines 738..744
                    salt/cloud/clouds/scaleway.py on lines 200..206
                    salt/cloud/clouds/scaleway.py on lines 304..310
                    salt/cloud/clouds/virtualbox.py on lines 176..182
                    salt/cloud/clouds/vmware.py on lines 2543..2549
                    salt/cloud/clouds/vmware.py on lines 3072..3078
                    salt/cloud/clouds/vultrpy.py on lines 292..298
                    salt/cloud/clouds/vultrpy.py on lines 465..471

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 66.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 10 locations. Consider refactoring.
                    Open

                        __utils__['cloud.fire_event'](
        'event',
        'requesting instance',
        'salt/cloud/{0}/requesting'.format(vm_['name']),
        args=__utils__['cloud.filter_event']('requesting', event_data, list(event_data)),
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 9 other locations - About 2 hrs to fix
                    salt/cloud/clouds/aliyun.py on lines 659..665
                    salt/cloud/clouds/digitalocean.py on lines 448..454
                    salt/cloud/clouds/ec2.py on lines 2860..2866
                    salt/cloud/clouds/msazure.py on lines 541..547
                    salt/cloud/clouds/nova.py on lines 1068..1074
                    salt/cloud/clouds/openstack.py on lines 767..773
                    salt/cloud/clouds/virtualbox.py on lines 192..198
                    salt/cloud/clouds/virtualbox.py on lines 218..224
                    salt/cloud/clouds/vmware.py on lines 2988..2994

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 65.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def start(name, call=None):
    '''
    Stop a VM in DimensionData.

    :param str name:
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 1 other location - About 2 hrs to fix
                    salt/cloud/clouds/dimensiondata.py on lines 483..503

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    def stop(name, call=None):
    '''
    Stop a VM in DimensionData.

    name:
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 1 other location - About 2 hrs to fix
                    salt/cloud/clouds/dimensiondata.py on lines 506..527

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            data = __utils__['cloud.wait_for_ip'](
            _query_node_data,
            update_args=(vm_, data),
            timeout=config.get_cloud_config_value(
                'wait_for_ip_timeout', vm_, __opts__, default=25 * 60),
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 1 other location - About 2 hrs to fix
                    salt/cloud/clouds/ec2.py on lines 2265..2273

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 58.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 6 locations. Consider refactoring.
                    Open

                        try:
        # Check for required profile parameters before sending any API calls.
        if vm_['profile'] and config.is_profile_configured(
                __opts__,
                __active_provider_name__ or 'dimensiondata',
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 5 other locations - About 1 hr to fix
                    salt/cloud/clouds/libvirt.py on lines 297..303
                    salt/cloud/clouds/oneandone.py on lines 745..753
                    salt/cloud/clouds/opennebula.py on lines 997..1003
                    salt/cloud/clouds/profitbricks.py on lines 821..829
                    salt/cloud/clouds/virtualbox.py on lines 144..152

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        try:
        data = conn.create_node(**kwargs)
    except Exception as exc:
        log.error(
            'Error creating %s on DIMENSIONDATA\n\n'
                    Severity: Major
                    Found in salt/cloud/clouds/dimensiondata.py and 2 other locations - About 1 hr to fix
                    salt/cloud/clouds/cloudstack.py on lines 375..386
                    salt/cloud/clouds/gce.py on lines 2560..2569

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 46.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status