Sign upLogin

saltstack/salt

View on GitHub
Star
salt/cloud/clouds/linode.py

Summary

Maintainability
F
1 wk
Test Coverage

File linode.py has 1268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Linode Cloud Module using Linode's REST API
===========================================
Severity: Major
Found in salt/cloud/clouds/linode.py - About 3 days to fix

    Function create has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single Linode VM.
    '''
    name = vm_['name']
    Severity: Minor
    Found in salt/cloud/clouds/linode.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _query has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def _query(action=None,
           command=None,
           args=None,
           method='GET',
           header_dict=None,
    Severity: Minor
    Found in salt/cloud/clouds/linode.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in function create. (23)
    Open

    def create(vm_):
    '''
    Create a single Linode VM.
    '''
    name = vm_['name']
    Severity: Minor
    Found in salt/cloud/clouds/linode.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function _decode_linode_plan_label has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    def _decode_linode_plan_label(label):
    '''
    Attempts to decode a user-supplied Linode plan label
    into the format in Linode API output
    Severity: Minor
    Found in salt/cloud/clouds/linode.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single Linode VM.
    '''
    name = vm_['name']
    Severity: Minor
    Found in salt/cloud/clouds/linode.py - About 1 hr to fix

      Function boot has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      def boot(name=None, kwargs=None, call=None):
    '''
    Boot a Linode.

    name
      Severity: Minor
      Found in salt/cloud/clouds/linode.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function get_ips has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_ips(linode_id=None):
    '''
    Returns public and private IP addresses.

    linode_id
      Severity: Minor
      Found in salt/cloud/clouds/linode.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _list_linodes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def _list_linodes(full=False):
    '''
    Helper function to format and parse linode data
    '''
    nodes = _query('linode', 'list')['DATA']
      Severity: Minor
      Found in salt/cloud/clouds/linode.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def create_config(kwargs=None, call=None):
    '''
    Creates a Linode Configuration Profile.

    name
      Severity: Minor
      Found in salt/cloud/clouds/linode.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return False
      Severity: Major
      Found in salt/cloud/clouds/linode.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return ret
        Severity: Major
        Found in salt/cloud/clouds/linode.py - About 30 mins to fix

          Function _wait_for_status has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          def _wait_for_status(linode_id, status=None, timeout=300, quiet=True):
    '''
    Wait for a certain status from Linode.

    linode_id
          Severity: Minor
          Found in salt/cloud/clouds/linode.py - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          def avail_images(call=None):
    '''
    Return available Linode images.

    CLI Example:
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 2 other locations - About 3 hrs to fix
          salt/cloud/clouds/linode.py on lines 136..159
          salt/cloud/clouds/linode.py on lines 162..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          def avail_locations(call=None):
    '''
    Return available Linode datacenter locations.

    CLI Example:
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 2 other locations - About 3 hrs to fix
          salt/cloud/clouds/linode.py on lines 110..133
          salt/cloud/clouds/linode.py on lines 162..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          def avail_sizes(call=None):
    '''
    Return available Linode sizes.

    CLI Example:
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 2 other locations - About 3 hrs to fix
          salt/cloud/clouds/linode.py on lines 110..133
          salt/cloud/clouds/linode.py on lines 136..159

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              __utils__['cloud.fire_event'](
        'event',
        'waiting for ssh',
        'salt/cloud/{0}/waiting_for_ssh'.format(name),
        sock_dir=__opts__['sock_dir'],
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 1 other location - About 2 hrs to fix
          salt/cloud/clouds/clc.py on lines 356..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 11 locations. Consider refactoring.
          Open

              __utils__['cloud.fire_event'](
        'event',
        'starting create',
        'salt/cloud/{0}/creating'.format(name),
        args=__utils__['cloud.filter_event']('creating', vm_, ['name', 'profile', 'provider', 'driver']),
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 10 other locations - About 2 hrs to fix
          salt/cloud/clouds/libvirt.py on lines 309..315
          salt/cloud/clouds/libvirt.py on lines 459..465
          salt/cloud/clouds/linode.py on lines 430..436
          salt/cloud/clouds/linode.py on lines 528..534
          salt/cloud/clouds/packet.py on lines 334..340
          salt/cloud/clouds/packet.py on lines 426..432
          salt/cloud/clouds/softlayer.py on lines 272..278
          salt/cloud/clouds/softlayer.py on lines 514..520
          salt/cloud/clouds/softlayer_hw.py on lines 240..246
          salt/cloud/clouds/softlayer_hw.py on lines 416..422

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 11 locations. Consider refactoring.
          Open

              __utils__['cloud.fire_event'](
        'event',
        'created instance',
        'salt/cloud/{0}/created'.format(name),
        args=__utils__['cloud.filter_event']('created', vm_, ['name', 'profile', 'provider', 'driver']),
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 10 other locations - About 2 hrs to fix
          salt/cloud/clouds/libvirt.py on lines 309..315
          salt/cloud/clouds/libvirt.py on lines 459..465
          salt/cloud/clouds/linode.py on lines 341..347
          salt/cloud/clouds/linode.py on lines 430..436
          salt/cloud/clouds/packet.py on lines 334..340
          salt/cloud/clouds/packet.py on lines 426..432
          salt/cloud/clouds/softlayer.py on lines 272..278
          salt/cloud/clouds/softlayer.py on lines 514..520
          salt/cloud/clouds/softlayer_hw.py on lines 240..246
          salt/cloud/clouds/softlayer_hw.py on lines 416..422

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 11 locations. Consider refactoring.
          Open

              __utils__['cloud.fire_event'](
        'event',
        'requesting instance',
        'salt/cloud/{0}/requesting'.format(name),
        args=__utils__['cloud.filter_event']('requesting', vm_, ['name', 'profile', 'provider', 'driver']),
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 10 other locations - About 2 hrs to fix
          salt/cloud/clouds/libvirt.py on lines 309..315
          salt/cloud/clouds/libvirt.py on lines 459..465
          salt/cloud/clouds/linode.py on lines 341..347
          salt/cloud/clouds/linode.py on lines 528..534
          salt/cloud/clouds/packet.py on lines 334..340
          salt/cloud/clouds/packet.py on lines 426..432
          salt/cloud/clouds/softlayer.py on lines 272..278
          salt/cloud/clouds/softlayer.py on lines 514..520
          salt/cloud/clouds/softlayer_hw.py on lines 240..246
          salt/cloud/clouds/softlayer_hw.py on lines 416..422

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 18 locations. Consider refactoring.
          Open

              try:
        # Check for required profile parameters before sending any API calls.
        if vm_['profile'] and config.is_profile_configured(__opts__,
                                                           __active_provider_name__ or 'linode',
                                                           vm_['profile'],
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 17 other locations - About 1 hr to fix
          salt/cloud/clouds/aliyun.py on lines 615..622
          salt/cloud/clouds/azurearm.py on lines 1384..1392
          salt/cloud/clouds/cloudstack.py on lines 270..277
          salt/cloud/clouds/digitalocean.py on lines 277..284
          salt/cloud/clouds/ec2.py on lines 2554..2561
          salt/cloud/clouds/gce.py on lines 2451..2458
          salt/cloud/clouds/gogrid.py on lines 86..93
          salt/cloud/clouds/joyent.py on lines 260..267
          salt/cloud/clouds/msazure.py on lines 419..426
          salt/cloud/clouds/nova.py on lines 938..945
          salt/cloud/clouds/parallels.py on lines 277..284
          salt/cloud/clouds/proxmox.py on lines 566..573
          salt/cloud/clouds/qingcloud.py on lines 658..665
          salt/cloud/clouds/scaleway.py on lines 190..197
          salt/cloud/clouds/softlayer.py on lines 248..255
          salt/cloud/clouds/softlayer_hw.py on lines 216..223
          salt/cloud/clouds/vmware.py on lines 2532..2540

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 23 locations. Consider refactoring.
          Open

              if __opts__.get('update_cachedir', False) is True:
        __utils__['cloud.delete_minion_cachedir'](name, __active_provider_name__.split(':')[0], __opts__)
          Severity: Major
          Found in salt/cloud/clouds/linode.py and 22 other locations - About 50 mins to fix
          salt/cloud/clouds/azurearm.py on lines 1528..1532
          salt/cloud/clouds/digitalocean.py on lines 868..869
          salt/cloud/clouds/ec2.py on lines 3417..3418
          salt/cloud/clouds/gce.py on lines 2377..2378
          salt/cloud/clouds/gogrid.py on lines 421..422
          salt/cloud/clouds/joyent.py on lines 429..430
          salt/cloud/clouds/lxc.py on lines 415..416
          salt/cloud/clouds/msazure.py on lines 947..948
          salt/cloud/clouds/nova.py on lines 569..570
          salt/cloud/clouds/oneandone.py on lines 918..922
          salt/cloud/clouds/opennebula.py on lines 1226..1230
          salt/cloud/clouds/openstack.py on lines 816..817
          salt/cloud/clouds/parallels.py on lines 561..562
          salt/cloud/clouds/profitbricks.py on lines 1023..1027
          salt/cloud/clouds/proxmox.py on lines 1194..1196
          salt/cloud/clouds/scaleway.py on lines 456..458
          salt/cloud/clouds/softlayer.py on lines 637..638
          salt/cloud/clouds/softlayer_hw.py on lines 547..548
          salt/cloud/clouds/vagrant.py on lines 308..310
          salt/cloud/clouds/vmware.py on lines 2513..2514
          salt/cloud/clouds/xen.py on lines 1046..1050
          salt/cloud/libcloudfuncs.py on lines 403..404

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status