Sign upLogin

saltstack/salt

View on GitHub
Star
salt/cloud/clouds/scaleway.py

Summary

Maintainability
F
4 days
Test Coverage

File scaleway.py has 365 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Scaleway Cloud Module
=====================
Severity: Minor
Found in salt/cloud/clouds/scaleway.py - About 4 hrs to fix

    Function create has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    def create(server_):
    '''
    Create a single BareMetal server from a data dict.
    '''
    try:
    Severity: Minor
    Found in salt/cloud/clouds/scaleway.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_nodes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def list_nodes(call=None):
    ''' Return a list of the BareMetal servers that are on the provider.
    '''
    if call == 'action':
        raise SaltCloudSystemExit(
    Severity: Minor
    Found in salt/cloud/clouds/scaleway.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def query(method='servers', server_id=None, command=None, args=None,
          http_method='GET', root='api_root'):
    ''' Make a call to the Scaleway API.
    '''
    Severity: Minor
    Found in salt/cloud/clouds/scaleway.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        try:
        data = salt.utils.cloud.wait_for_ip(
            __query_node_data,
            update_args=(server_['name'],),
            timeout=config.get_cloud_config_value(
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 3 other locations - About 6 hrs to fix
    salt/cloud/clouds/aliyun.py on lines 694..710
    salt/cloud/clouds/digitalocean.py on lines 481..497
    salt/cloud/clouds/parallels.py on lines 326..342

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 112.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    def get_image(server_):
    ''' Return the image object to use.
    '''
    images = avail_images()
    server_image = six.text_type(config.get_cloud_config_value(
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 2 other locations - About 6 hrs to fix
    salt/cloud/clouds/digitalocean.py on lines 245..259
    salt/cloud/clouds/opennebula.py on lines 640..655

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        for image in items['images']:
        ret[image['id']] = {}
        for item in image:
            ret[image['id']][item] = six.text_type(image[item])
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 2 other locations - About 3 hrs to fix
    salt/cloud/clouds/aliyun.py on lines 912..915
    salt/cloud/clouds/qingcloud.py on lines 227..230

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        __utils__['cloud.fire_event'](
        'event',
        'requesting instance',
        'salt/cloud/{0}/requesting'.format(server_['name']),
        args={
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 6 other locations - About 2 hrs to fix
    salt/cloud/clouds/gogrid.py on lines 125..133
    salt/cloud/clouds/joyent.py on lines 301..309
    salt/cloud/clouds/nova.py on lines 685..693
    salt/cloud/clouds/parallels.py on lines 258..266
    salt/cloud/clouds/qingcloud.py on lines 691..699
    salt/cloud/clouds/vultrpy.py on lines 329..337

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 38 locations. Consider refactoring.
    Open

        __utils__['cloud.fire_event'](
        'event',
        'created instance',
        'salt/cloud/{0}/created'.format(server_['name']),
        args=__utils__['cloud.filter_event']('created', server_, ['name', 'profile', 'provider', 'driver']),
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 37 other locations - About 2 hrs to fix
    salt/cloud/clouds/aliyun.py on lines 625..631
    salt/cloud/clouds/aliyun.py on lines 732..738
    salt/cloud/clouds/azurearm.py on lines 1349..1359
    salt/cloud/clouds/azurearm.py on lines 1398..1406
    salt/cloud/clouds/azurearm.py on lines 1480..1489
    salt/cloud/clouds/digitalocean.py on lines 287..293
    salt/cloud/clouds/digitalocean.py on lines 537..543
    salt/cloud/clouds/dimensiondata.py on lines 207..213
    salt/cloud/clouds/dimensiondata.py on lines 337..343
    salt/cloud/clouds/ec2.py on lines 2579..2585
    salt/cloud/clouds/gce.py on lines 2461..2467
    salt/cloud/clouds/gce.py on lines 2551..2557
    salt/cloud/clouds/gce.py on lines 2635..2641
    salt/cloud/clouds/gogrid.py on lines 96..102
    salt/cloud/clouds/gogrid.py on lines 180..186
    salt/cloud/clouds/joyent.py on lines 274..280
    salt/cloud/clouds/joyent.py on lines 325..331
    salt/cloud/clouds/lxc.py on lines 440..446
    salt/cloud/clouds/lxc.py on lines 460..466
    salt/cloud/clouds/lxc.py on lines 488..494
    salt/cloud/clouds/msazure.py on lines 429..435
    salt/cloud/clouds/msazure.py on lines 683..689
    salt/cloud/clouds/nova.py on lines 961..967
    salt/cloud/clouds/opennebula.py on lines 1006..1012
    salt/cloud/clouds/openstack.py on lines 684..690
    salt/cloud/clouds/packet.py on lines 347..353
    salt/cloud/clouds/parallels.py on lines 287..293
    salt/cloud/clouds/parallels.py on lines 356..362
    salt/cloud/clouds/proxmox.py on lines 578..585
    salt/cloud/clouds/qingcloud.py on lines 668..674
    salt/cloud/clouds/qingcloud.py on lines 738..744
    salt/cloud/clouds/scaleway.py on lines 200..206
    salt/cloud/clouds/virtualbox.py on lines 176..182
    salt/cloud/clouds/vmware.py on lines 2543..2549
    salt/cloud/clouds/vmware.py on lines 3072..3078
    salt/cloud/clouds/vultrpy.py on lines 292..298
    salt/cloud/clouds/vultrpy.py on lines 465..471

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 38 locations. Consider refactoring.
    Open

        __utils__['cloud.fire_event'](
        'event',
        'starting create',
        'salt/cloud/{0}/creating'.format(server_['name']),
        args=__utils__['cloud.filter_event']('creating', server_, ['name', 'profile', 'provider', 'driver']),
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 37 other locations - About 2 hrs to fix
    salt/cloud/clouds/aliyun.py on lines 625..631
    salt/cloud/clouds/aliyun.py on lines 732..738
    salt/cloud/clouds/azurearm.py on lines 1349..1359
    salt/cloud/clouds/azurearm.py on lines 1398..1406
    salt/cloud/clouds/azurearm.py on lines 1480..1489
    salt/cloud/clouds/digitalocean.py on lines 287..293
    salt/cloud/clouds/digitalocean.py on lines 537..543
    salt/cloud/clouds/dimensiondata.py on lines 207..213
    salt/cloud/clouds/dimensiondata.py on lines 337..343
    salt/cloud/clouds/ec2.py on lines 2579..2585
    salt/cloud/clouds/gce.py on lines 2461..2467
    salt/cloud/clouds/gce.py on lines 2551..2557
    salt/cloud/clouds/gce.py on lines 2635..2641
    salt/cloud/clouds/gogrid.py on lines 96..102
    salt/cloud/clouds/gogrid.py on lines 180..186
    salt/cloud/clouds/joyent.py on lines 274..280
    salt/cloud/clouds/joyent.py on lines 325..331
    salt/cloud/clouds/lxc.py on lines 440..446
    salt/cloud/clouds/lxc.py on lines 460..466
    salt/cloud/clouds/lxc.py on lines 488..494
    salt/cloud/clouds/msazure.py on lines 429..435
    salt/cloud/clouds/msazure.py on lines 683..689
    salt/cloud/clouds/nova.py on lines 961..967
    salt/cloud/clouds/opennebula.py on lines 1006..1012
    salt/cloud/clouds/openstack.py on lines 684..690
    salt/cloud/clouds/packet.py on lines 347..353
    salt/cloud/clouds/parallels.py on lines 287..293
    salt/cloud/clouds/parallels.py on lines 356..362
    salt/cloud/clouds/proxmox.py on lines 578..585
    salt/cloud/clouds/qingcloud.py on lines 668..674
    salt/cloud/clouds/qingcloud.py on lines 738..744
    salt/cloud/clouds/scaleway.py on lines 304..310
    salt/cloud/clouds/virtualbox.py on lines 176..182
    salt/cloud/clouds/vmware.py on lines 2543..2549
    salt/cloud/clouds/vmware.py on lines 3072..3078
    salt/cloud/clouds/vultrpy.py on lines 292..298
    salt/cloud/clouds/vultrpy.py on lines 465..471

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    def show_instance(name, call=None):
    ''' Show the details from a Scaleway BareMetal server.
    '''
    if call != 'action':
        raise SaltCloudSystemExit(
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 2 other locations - About 1 hr to fix
    salt/cloud/clouds/digitalocean.py on lines 622..632
    salt/cloud/clouds/opennebula.py on lines 1897..1923

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 18 locations. Consider refactoring.
    Open

        try:
        # Check for required profile parameters before sending any API calls.
        if server_['profile'] and config.is_profile_configured(__opts__,
                                                               __active_provider_name__ or 'scaleway',
                                                               server_['profile'],
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 17 other locations - About 1 hr to fix
    salt/cloud/clouds/aliyun.py on lines 615..622
    salt/cloud/clouds/azurearm.py on lines 1384..1392
    salt/cloud/clouds/cloudstack.py on lines 270..277
    salt/cloud/clouds/digitalocean.py on lines 277..284
    salt/cloud/clouds/ec2.py on lines 2554..2561
    salt/cloud/clouds/gce.py on lines 2451..2458
    salt/cloud/clouds/gogrid.py on lines 86..93
    salt/cloud/clouds/joyent.py on lines 260..267
    salt/cloud/clouds/linode.py on lines 328..335
    salt/cloud/clouds/msazure.py on lines 419..426
    salt/cloud/clouds/nova.py on lines 938..945
    salt/cloud/clouds/parallels.py on lines 277..284
    salt/cloud/clouds/proxmox.py on lines 566..573
    salt/cloud/clouds/qingcloud.py on lines 658..665
    salt/cloud/clouds/softlayer.py on lines 248..255
    salt/cloud/clouds/softlayer_hw.py on lines 216..223
    salt/cloud/clouds/vmware.py on lines 2532..2540

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    def script(server_):
    ''' Return the script deployment object.
    '''
    return salt.utils.cloud.os_script(
        config.get_cloud_config_value('script', server_, __opts__),
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 4 other locations - About 1 hr to fix
    salt/cloud/clouds/ec2.py on lines 968..977
    salt/cloud/clouds/msazure.py on lines 139..148
    salt/cloud/clouds/oneandone.py on lines 485..494
    salt/cloud/clouds/parallels.py on lines 435..444

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

        if __opts__.get('update_cachedir', False) is True:
        __utils__['cloud.delete_minion_cachedir'](
            name, __active_provider_name__.split(':')[0], __opts__
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 22 other locations - About 50 mins to fix
    salt/cloud/clouds/azurearm.py on lines 1528..1532
    salt/cloud/clouds/digitalocean.py on lines 868..869
    salt/cloud/clouds/ec2.py on lines 3417..3418
    salt/cloud/clouds/gce.py on lines 2377..2378
    salt/cloud/clouds/gogrid.py on lines 421..422
    salt/cloud/clouds/joyent.py on lines 429..430
    salt/cloud/clouds/linode.py on lines 758..759
    salt/cloud/clouds/lxc.py on lines 415..416
    salt/cloud/clouds/msazure.py on lines 947..948
    salt/cloud/clouds/nova.py on lines 569..570
    salt/cloud/clouds/oneandone.py on lines 918..922
    salt/cloud/clouds/opennebula.py on lines 1226..1230
    salt/cloud/clouds/openstack.py on lines 816..817
    salt/cloud/clouds/parallels.py on lines 561..562
    salt/cloud/clouds/profitbricks.py on lines 1023..1027
    salt/cloud/clouds/proxmox.py on lines 1194..1196
    salt/cloud/clouds/softlayer.py on lines 637..638
    salt/cloud/clouds/softlayer_hw.py on lines 547..548
    salt/cloud/clouds/vagrant.py on lines 308..310
    salt/cloud/clouds/vmware.py on lines 2513..2514
    salt/cloud/clouds/xen.py on lines 1046..1050
    salt/cloud/libcloudfuncs.py on lines 403..404

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        try:
        ret = create_node(kwargs)
    except Exception as exc:
        log.error(
            'Error creating %s on Scaleway\n\n'
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 2 other locations - About 50 mins to fix
    salt/cloud/clouds/digitalocean.py on lines 457..468
    salt/cloud/clouds/parallels.py on lines 298..309

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        if key_filename is not None and not os.path.isfile(key_filename):
        raise SaltCloudConfigError(
            'The defined key_filename \'{0}\' does not exist'.format(
    Severity: Major
    Found in salt/cloud/clouds/scaleway.py and 7 other locations - About 30 mins to fix
    salt/cloud/clouds/digitalocean.py on lines 327..329
    salt/cloud/clouds/libvirt.py on lines 321..323
    salt/cloud/clouds/nova.py on lines 952..954
    salt/cloud/clouds/opennebula.py on lines 1125..1127
    salt/cloud/clouds/openstack.py on lines 675..677
    salt/utils/cloud.py on lines 414..416
    salt/utils/cloud.py on lines 1463..1465

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 40.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status