Sign upLogin

saltstack/salt

View on GitHub
Star
salt/cloud/clouds/vultrpy.py

Summary

Maintainability
F
4 days
Test Coverage

File vultrpy.py has 407 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Vultr Cloud Module using python-vultr bindings
==============================================
Severity: Minor
Found in salt/cloud/clouds/vultrpy.py - About 5 hrs to fix

    Function create has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single VM from a data dict
    '''
    if 'driver' not in vm_:
    Severity: Minor
    Found in salt/cloud/clouds/vultrpy.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def create(vm_):
    '''
    Create a single VM from a data dict
    '''
    if 'driver' not in vm_:
    Severity: Minor
    Found in salt/cloud/clouds/vultrpy.py - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return False
      Severity: Major
      Found in salt/cloud/clouds/vultrpy.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return ret
        Severity: Major
        Found in salt/cloud/clouds/vultrpy.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return False
          Severity: Major
          Found in salt/cloud/clouds/vultrpy.py - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def wait_for_server_state():
        '''
        Wait for the IP address to become available
        '''
        data = show_instance(vm_['name'], call='action')
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 1 other location - About 3 hrs to fix
            salt/cloud/clouds/vultrpy.py on lines 401..411

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def wait_for_status():
        '''
        Wait for the IP address to become available
        '''
        data = show_instance(vm_['name'], call='action')
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 1 other location - About 3 hrs to fix
            salt/cloud/clouds/vultrpy.py on lines 413..423

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                __utils__['cloud.fire_event'](
        'event',
        'requesting instance',
        'salt/cloud/{0}/requesting'.format(vm_['name']),
        args={
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 6 other locations - About 2 hrs to fix
            salt/cloud/clouds/gogrid.py on lines 125..133
            salt/cloud/clouds/joyent.py on lines 301..309
            salt/cloud/clouds/nova.py on lines 685..693
            salt/cloud/clouds/parallels.py on lines 258..266
            salt/cloud/clouds/qingcloud.py on lines 691..699
            salt/cloud/clouds/scaleway.py on lines 241..249

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 38 locations. Consider refactoring.
            Open

                __utils__['cloud.fire_event'](
        'event',
        'created instance',
        'salt/cloud/{0}/created'.format(vm_['name']),
        args=__utils__['cloud.filter_event']('created', vm_, ['name', 'profile', 'provider', 'driver']),
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 37 other locations - About 2 hrs to fix
            salt/cloud/clouds/aliyun.py on lines 625..631
            salt/cloud/clouds/aliyun.py on lines 732..738
            salt/cloud/clouds/azurearm.py on lines 1349..1359
            salt/cloud/clouds/azurearm.py on lines 1398..1406
            salt/cloud/clouds/azurearm.py on lines 1480..1489
            salt/cloud/clouds/digitalocean.py on lines 287..293
            salt/cloud/clouds/digitalocean.py on lines 537..543
            salt/cloud/clouds/dimensiondata.py on lines 207..213
            salt/cloud/clouds/dimensiondata.py on lines 337..343
            salt/cloud/clouds/ec2.py on lines 2579..2585
            salt/cloud/clouds/gce.py on lines 2461..2467
            salt/cloud/clouds/gce.py on lines 2551..2557
            salt/cloud/clouds/gce.py on lines 2635..2641
            salt/cloud/clouds/gogrid.py on lines 96..102
            salt/cloud/clouds/gogrid.py on lines 180..186
            salt/cloud/clouds/joyent.py on lines 274..280
            salt/cloud/clouds/joyent.py on lines 325..331
            salt/cloud/clouds/lxc.py on lines 440..446
            salt/cloud/clouds/lxc.py on lines 460..466
            salt/cloud/clouds/lxc.py on lines 488..494
            salt/cloud/clouds/msazure.py on lines 429..435
            salt/cloud/clouds/msazure.py on lines 683..689
            salt/cloud/clouds/nova.py on lines 961..967
            salt/cloud/clouds/opennebula.py on lines 1006..1012
            salt/cloud/clouds/openstack.py on lines 684..690
            salt/cloud/clouds/packet.py on lines 347..353
            salt/cloud/clouds/parallels.py on lines 287..293
            salt/cloud/clouds/parallels.py on lines 356..362
            salt/cloud/clouds/proxmox.py on lines 578..585
            salt/cloud/clouds/qingcloud.py on lines 668..674
            salt/cloud/clouds/qingcloud.py on lines 738..744
            salt/cloud/clouds/scaleway.py on lines 200..206
            salt/cloud/clouds/scaleway.py on lines 304..310
            salt/cloud/clouds/virtualbox.py on lines 176..182
            salt/cloud/clouds/vmware.py on lines 2543..2549
            salt/cloud/clouds/vmware.py on lines 3072..3078
            salt/cloud/clouds/vultrpy.py on lines 292..298

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 38 locations. Consider refactoring.
            Open

                __utils__['cloud.fire_event'](
        'event',
        'starting create',
        'salt/cloud/{0}/creating'.format(vm_['name']),
        args=__utils__['cloud.filter_event']('creating', vm_, ['name', 'profile', 'provider', 'driver']),
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 37 other locations - About 2 hrs to fix
            salt/cloud/clouds/aliyun.py on lines 625..631
            salt/cloud/clouds/aliyun.py on lines 732..738
            salt/cloud/clouds/azurearm.py on lines 1349..1359
            salt/cloud/clouds/azurearm.py on lines 1398..1406
            salt/cloud/clouds/azurearm.py on lines 1480..1489
            salt/cloud/clouds/digitalocean.py on lines 287..293
            salt/cloud/clouds/digitalocean.py on lines 537..543
            salt/cloud/clouds/dimensiondata.py on lines 207..213
            salt/cloud/clouds/dimensiondata.py on lines 337..343
            salt/cloud/clouds/ec2.py on lines 2579..2585
            salt/cloud/clouds/gce.py on lines 2461..2467
            salt/cloud/clouds/gce.py on lines 2551..2557
            salt/cloud/clouds/gce.py on lines 2635..2641
            salt/cloud/clouds/gogrid.py on lines 96..102
            salt/cloud/clouds/gogrid.py on lines 180..186
            salt/cloud/clouds/joyent.py on lines 274..280
            salt/cloud/clouds/joyent.py on lines 325..331
            salt/cloud/clouds/lxc.py on lines 440..446
            salt/cloud/clouds/lxc.py on lines 460..466
            salt/cloud/clouds/lxc.py on lines 488..494
            salt/cloud/clouds/msazure.py on lines 429..435
            salt/cloud/clouds/msazure.py on lines 683..689
            salt/cloud/clouds/nova.py on lines 961..967
            salt/cloud/clouds/opennebula.py on lines 1006..1012
            salt/cloud/clouds/openstack.py on lines 684..690
            salt/cloud/clouds/packet.py on lines 347..353
            salt/cloud/clouds/parallels.py on lines 287..293
            salt/cloud/clouds/parallels.py on lines 356..362
            salt/cloud/clouds/proxmox.py on lines 578..585
            salt/cloud/clouds/qingcloud.py on lines 668..674
            salt/cloud/clouds/qingcloud.py on lines 738..744
            salt/cloud/clouds/scaleway.py on lines 200..206
            salt/cloud/clouds/scaleway.py on lines 304..310
            salt/cloud/clouds/virtualbox.py on lines 176..182
            salt/cloud/clouds/vmware.py on lines 2543..2549
            salt/cloud/clouds/vmware.py on lines 3072..3078
            salt/cloud/clouds/vultrpy.py on lines 465..471

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 66.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for node in nodes:
        ret[node] = {}
        for prop in 'id', 'image', 'size', 'state', 'private_ips', 'public_ips':
            ret[node][prop] = nodes[node][prop]
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 1 other location - About 2 hrs to fix
            salt/cloud/clouds/gogrid.py on lines 212..215

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                for key, vm_size in six.iteritems(sizes):
        DETAILS['avail_sizes'][vm_size['name']] = vm_size
        DETAILS['avail_sizes'][key] = vm_size
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 2 other locations - About 1 hr to fix
            salt/cloud/clouds/vultrpy.py on lines 112..114
            salt/cloud/clouds/vultrpy.py on lines 116..118

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                for key, location in six.iteritems(locations):
        DETAILS['avail_locations'][location['name']] = location
        DETAILS['avail_locations'][key] = location
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 2 other locations - About 1 hr to fix
            salt/cloud/clouds/vultrpy.py on lines 116..118
            salt/cloud/clouds/vultrpy.py on lines 120..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                for key, image in six.iteritems(images):
        DETAILS['avail_images'][image['name']] = image
        DETAILS['avail_images'][key] = image
            Severity: Major
            Found in salt/cloud/clouds/vultrpy.py and 2 other locations - About 1 hr to fix
            salt/cloud/clouds/vultrpy.py on lines 112..114
            salt/cloud/clouds/vultrpy.py on lines 120..122

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                vm_['password'] = __utils__['cloud.wait_for_fun'](
        wait_for_default_password,
        timeout=config.get_cloud_config_value(
            'wait_for_fun_timeout', vm_, __opts__, default=15 * 60),
            Severity: Minor
            Found in salt/cloud/clouds/vultrpy.py and 1 other location - About 45 mins to fix
            salt/cloud/clouds/vultrpy.py on lines 425..428

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                vm_['ssh_host'] = __utils__['cloud.wait_for_fun'](
        wait_for_hostname,
        timeout=config.get_cloud_config_value(
            'wait_for_fun_timeout', vm_, __opts__, default=15 * 60),
            Severity: Minor
            Found in salt/cloud/clouds/vultrpy.py and 1 other location - About 45 mins to fix
            salt/cloud/clouds/vultrpy.py on lines 430..433

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 43.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status