Sign upLogin

saltstack/salt

View on GitHub
Star
salt/engines/sqs_events.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _get_sqs_conn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def _get_sqs_conn(profile, region=None, key=None, keyid=None):
    '''
    Get a boto connection to SQS.
    '''
    if profile:
Severity: Minor
Found in salt/engines/sqs_events.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _process_queue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def _process_queue(q, q_name, fire_master, tag='salt/engine/sqs', owner_acct_id=None, message_format=None):
    if not q:
        log.warning(
            'failure connecting to queue: %s, waiting 10 seconds.',
            ':'.join([_f for _f in (six.text_type(owner_acct_id), q_name) if _f])
Severity: Minor
Found in salt/engines/sqs_events.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status