Sign upLogin

saltstack/salt

View on GitHub
Star
salt/modules/beacons.py

Summary

Maintainability
F
1 wk
Test Coverage

File beacons.py has 576 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Module for managing the Salt beacons on a minion

.. versionadded:: 2015.8.0
Severity: Major
Found in salt/modules/beacons.py - About 1 day to fix

    Function modify has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
    Open

    def modify(name, beacon_data, **kwargs):
    '''
    Modify an existing beacon.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function add has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    def add(name, beacon_data, **kwargs):
    '''
    Add a beacon on the minion

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function disable_beacon has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def disable_beacon(name, **kwargs):
    '''
    Disable a beacon on the minion.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function enable_beacon has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    def enable_beacon(name, **kwargs):
    '''
    Enable a beacon on the minion.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in function modify. (22)
    Open

    def modify(name, beacon_data, **kwargs):
    '''
    Modify an existing beacon.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function delete has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    def delete(name, **kwargs):
    '''
    Delete a beacon item.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function disable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def disable(**kwargs):
    '''
    Disable all beacons jobs on the minion.

    Returns:
    Severity: Minor
    Found in salt/modules/beacons.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function enable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    def enable(**kwargs):
    '''
    Enable all beacons on the minion.

    Returns:
    Severity: Minor
    Found in salt/modules/beacons.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reset has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def reset(**kwargs):
    '''
    Reset the beacon configuration on the minion.

    CLI Example:
    Severity: Minor
    Found in salt/modules/beacons.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_ has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    def list_(return_yaml=True,
          include_pillar=True,
          include_opts=True,
          **kwargs):
    '''
    Severity: Minor
    Found in salt/modules/beacons.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_available has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    def list_available(return_yaml=True, **kwargs):
    '''
    List the beacons currently available on the minion.

    Args:
    Severity: Minor
    Found in salt/modules/beacons.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if name in beacons and beacons[name] == beacon_data:
                            ret['result'] = True
                            ret['comment'] = 'Modified beacon: {0}.'.format(name)
                    elif event_ret:
    Severity: Major
    Found in salt/modules/beacons.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if 'enabled' in beacons and not beacons['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Disabled beacons on minion.'
                        else:
                            ret['result'] = False
      Severity: Major
      Found in salt/modules/beacons.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if 'enabled' in beacons and beacons['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Enabled beacons on minion.'
                        else:
                            ret['result'] = False
        Severity: Major
        Found in salt/modules/beacons.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if name in beacons and beacons[name] == beacon_data:
                            ret['result'] = True
                            ret['comment'] = 'Added beacon: {0}.'.format(name)
                    else:
          Severity: Major
          Found in salt/modules/beacons.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if 'enabled' in beacon_config_dict and beacon_config_dict['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Enabled beacon {0} on minion.' \
                                             ''.format(name)
                        else:
            Severity: Major
            Found in salt/modules/beacons.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if 'enabled' in beacon_config_dict and not beacon_config_dict['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Disabled beacon {0} on minion.' \
                                             ''.format(name)
                        else:
              Severity: Major
              Found in salt/modules/beacons.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if name not in beacons:
                            ret['result'] = True
                            ret['comment'] = 'Deleted beacon: {0}.'.format(name)
                            return ret
                    elif event_ret:
                Severity: Major
                Found in salt/modules/beacons.py - About 45 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return ret
                  Severity: Major
                  Found in salt/modules/beacons.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return ret
                    Severity: Major
                    Found in salt/modules/beacons.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return ret
                      Severity: Major
                      Found in salt/modules/beacons.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return ret
                        Severity: Major
                        Found in salt/modules/beacons.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return ret
                          Severity: Major
                          Found in salt/modules/beacons.py - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    try:
            # Attempt to load the beacon module so we have access to the validate function
            with salt.utils.event.get_event('minion', opts=__opts__, listen=True) as event_bus:
                res = __salt__['event.fire']({'name': name,
                                              'beacon_data': beacon_data,
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 1 day to fix
                            salt/modules/beacons.py on lines 188..213

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 161.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    try:
            # Attempt to load the beacon module so we have access to the validate function
            with salt.utils.event.get_event('minion', opts=__opts__, listen=True) as event_bus:
                res = __salt__['event.fire']({'name': name,
                                              'beacon_data': beacon_data,
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 1 day to fix
                            salt/modules/beacons.py on lines 276..300

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 161.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        beacons = event_ret['beacons']
                        if name not in beacons:
                            ret['result'] = True
                            ret['comment'] = 'Deleted beacon: {0}.'.format(name)
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 3 hrs to fix
                            salt/modules/beacons.py on lines 338..350

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 68.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        beacons = event_ret['beacons']
                        if name in beacons and beacons[name] == beacon_data:
                            ret['result'] = True
                            ret['comment'] = 'Modified beacon: {0}.'.format(name)
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 3 hrs to fix
                            salt/modules/beacons.py on lines 396..409

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 68.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                    if 'enabled' in beacons and not beacons['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Disabled beacons on minion.'
                        else:
                            ret['result'] = False
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 3 hrs to fix
                            salt/modules/schedule.py on lines 824..829

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 70.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        beacons = event_ret['beacons']
                        if name in beacons and beacons[name] == beacon_data:
                            ret['result'] = True
                            ret['comment'] = 'Added beacon: {0}.'.format(name)
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 2 hrs to fix
                            salt/modules/beacons.py on lines 338..342

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 67.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                    if 'enabled' in beacons and beacons['enabled']:
                            ret['result'] = True
                            ret['comment'] = 'Enabled beacons on minion.'
                        else:
                            ret['result'] = False
                            Severity: Major
                            Found in salt/modules/beacons.py and 1 other location - About 2 hrs to fix
                            salt/modules/schedule.py on lines 784..789

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 66.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        beacons = event_ret['beacons']
                        beacon_config_dict = _get_beacon_config_dict(beacons[name])

                        if 'enabled' in beacon_config_dict and beacon_config_dict['enabled']:
                            Severity: Major
                            Found in salt/modules/beacons.py and 2 other locations - About 2 hrs to fix
                            salt/modules/beacons.py on lines 673..689
                            salt/modules/beacons.py on lines 726..734

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 61.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        ret['result'] = True
                        ret['comment'] = 'Beacon configuration reset.'
                    elif event_ret:
                        ret['result'] = False
                            Severity: Major
                            Found in salt/modules/beacons.py and 2 other locations - About 2 hrs to fix
                            salt/modules/beacons.py on lines 599..616
                            salt/modules/beacons.py on lines 673..689

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 61.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                                if event_ret and event_ret['complete']:
                        beacons = event_ret['beacons']
                        beacon_config_dict = _get_beacon_config_dict(beacons[name])

                        if 'enabled' in beacon_config_dict and not beacon_config_dict['enabled']:
                            Severity: Major
                            Found in salt/modules/beacons.py and 2 other locations - About 2 hrs to fix
                            salt/modules/beacons.py on lines 599..616
                            salt/modules/beacons.py on lines 726..734

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 61.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                if beacons:
        if return_yaml:
            tmp = {'beacons': beacons}
            return salt.utils.yaml.safe_dump(tmp, default_flow_style=False)
        else:
                            Severity: Major
                            Found in salt/modules/beacons.py and 2 other locations - About 1 hr to fix
                            salt/modules/beacons.py on lines 84..91
                            salt/modules/schedule.py on lines 152..159

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                if beacons:
        if return_yaml:
            tmp = {'beacons': beacons}
            return salt.utils.yaml.safe_dump(tmp, default_flow_style=False)
        else:
                            Severity: Major
                            Found in salt/modules/beacons.py and 2 other locations - About 1 hr to fix
                            salt/modules/beacons.py on lines 133..140
                            salt/modules/schedule.py on lines 152..159

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 8 locations. Consider refactoring.
                            Open

                                    if name not in _beacons:
            ret['comment'] = 'Beacon {0} is not currently configured.' \
                             ''.format(name)
            ret['result'] = False
            return ret
                            Severity: Major
                            Found in salt/modules/beacons.py and 7 other locations - About 35 mins to fix
                            salt/modules/beacons.py on lines 584..588
                            salt/modules/schedule.py on lines 512..515
                            salt/runners/lxc.py on lines 275..278
                            salt/states/module.py on lines 519..522
                            salt/states/selinux.py on lines 155..158
                            salt/states/selinux.py on lines 235..238
                            salt/states/selinux.py on lines 306..309

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 41.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 8 locations. Consider refactoring.
                            Open

                                    if name not in _beacons:
            ret['comment'] = 'Beacon {0} is not currently configured.' \
                             ''.format(name)
            ret['result'] = False
            return ret
                            Severity: Major
                            Found in salt/modules/beacons.py and 7 other locations - About 35 mins to fix
                            salt/modules/beacons.py on lines 658..662
                            salt/modules/schedule.py on lines 512..515
                            salt/runners/lxc.py on lines 275..278
                            salt/states/module.py on lines 519..522
                            salt/states/selinux.py on lines 155..158
                            salt/states/selinux.py on lines 235..238
                            salt/states/selinux.py on lines 306..309

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 41.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status