Sign upLogin

saltstack/salt

View on GitHub
Star
salt/modules/poudriere.py

Summary

Maintainability
A
1 hr
Test Coverage

Function delete_jail has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def delete_jail(name):
    '''
    Deletes poudriere jail with `name`

    CLI Example:
Severity: Minor
Found in salt/modules/poudriere.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function bulk_build has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def bulk_build(jail, pkg_file, keep=False):
    '''
    Run bulk build on poudriere server.

    Return number of pkg builds, failures, and errors, on error dump to CLI
Severity: Minor
Found in salt/modules/poudriere.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_pkgng_aware has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def make_pkgng_aware(jname):
    '''
    Make jail ``jname`` pkgng aware

    CLI Example:
Severity: Minor
Found in salt/modules/poudriere.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status