Sign upLogin

saltstack/salt

View on GitHub
Star
salt/returners/nagios_nrdp_return.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _post_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def _post_data(options=None, xml=None):
    '''
    Post data to Nagios NRDP
    '''
    params = {'token': options['token'].strip(), 'cmd': 'submitcheck', 'XMLDATA': xml}
Severity: Minor
Found in salt/returners/nagios_nrdp_return.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _prepare_xml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def _prepare_xml(options=None, state=None):
    '''
    Get the requests options from salt.
    '''
Severity: Minor
Found in salt/returners/nagios_nrdp_return.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status