Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/boto_elasticsearch_domain.py

Summary

Maintainability
F
4 days
Test Coverage

Function present has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

def present(name, DomainName,
            ElasticsearchClusterConfig=None,
            EBSOptions=None,
            AccessPolicies=None,
            SnapshotOptions=None,
Severity: Minor
Found in salt/states/boto_elasticsearch_domain.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File boto_elasticsearch_domain.py has 311 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage Elasticsearch Domains
============================
Severity: Minor
Found in salt/states/boto_elasticsearch_domain.py - About 3 hrs to fix

    Avoid too many return statements within this function.
    Open

                return ret
    Severity: Major
    Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return ret
      Severity: Major
      Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return ret
        Severity: Major
        Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return ret
          Severity: Major
          Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return ret
            Severity: Major
            Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return ret
              Severity: Major
              Found in salt/states/boto_elasticsearch_domain.py - About 30 mins to fix

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                def absent(name, DomainName,
                  region=None, key=None, keyid=None, profile=None):
    '''
    Ensure domain with passed properties is absent.
                Severity: Major
                Found in salt/states/boto_elasticsearch_domain.py and 3 other locations - About 3 days to fix
                salt/states/boto_cloudtrail.py on lines 318..374
                salt/states/boto_iot.py on lines 749..805
                salt/states/boto_lambda.py on lines 511..569

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 342.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 13 locations. Consider refactoring.
                Open

                        if __opts__['test']:
            msg = 'Domain {0} set to be modified.'.format(DomainName)
            ret['comment'] = msg
            ret['result'] = None
            return ret
                Severity: Major
                Found in salt/states/boto_elasticsearch_domain.py and 12 other locations - About 1 hr to fix
                salt/states/boto_cloudtrail.py on lines 257..261
                salt/states/boto_cloudwatch_alarm.py on lines 150..154
                salt/states/boto_cloudwatch_alarm.py on lines 164..168
                salt/states/boto_cloudwatch_event.py on lines 222..226
                salt/states/boto_elasticache.py on lines 232..236
                salt/states/boto_iot.py on lines 378..382
                salt/states/boto_sns.py on lines 117..121
                salt/states/boto_vpc.py on lines 1005..1009
                salt/states/boto_vpc.py on lines 1117..1121
                salt/states/boto_vpc.py on lines 1200..1204
                salt/states/pyrax_queues.py on lines 51..55
                salt/states/telemetry_alert.py on lines 141..145

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status