Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/lxd_container.py

Summary

Maintainability
F
1 wk
Test Coverage

File lxd_container.py has 694 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage LXD containers.

.. versionadded:: 2019.2.0
Severity: Major
Found in salt/states/lxd_container.py - About 1 day to fix

    Function present has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
    Open

    def present(name,
            running=None,
            source=None,
            profiles=None,
            config=None,
    Severity: Minor
    Found in salt/states/lxd_container.py - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity is too high in function present. (32)
    Open

    def present(name,
            running=None,
            source=None,
            profiles=None,
            config=None,
    Severity: Minor
    Found in salt/states/lxd_container.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function running has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def running(name,
            restart=False,
            remote_addr=None,
            cert=None,
            key=None,
    Severity: Minor
    Found in salt/states/lxd_container.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function frozen has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def frozen(name,
           start=True,
           remote_addr=None,
           cert=None,
           key=None,
    Severity: Minor
    Found in salt/states/lxd_container.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function migrated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def migrated(name,
             remote_addr,
             cert,
             key,
             verify_cert,
    Severity: Minor
    Found in salt/states/lxd_container.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return _success(
    Severity: Major
    Found in salt/states/lxd_container.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return _unchanged(
      Severity: Major
      Found in salt/states/lxd_container.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return _error(ret, six.text_type(e))
        Severity: Major
        Found in salt/states/lxd_container.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return _success(ret, ret['changes']['restarted'])
          Severity: Major
          Found in salt/states/lxd_container.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return _unchanged(
            Severity: Major
            Found in salt/states/lxd_container.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return _success(ret, '{0} changes'.format(len(ret['changes'].keys())))
              Severity: Major
              Found in salt/states/lxd_container.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return _unchanged(ret, ret['changes']['started'])
                Severity: Major
                Found in salt/states/lxd_container.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return _unchanged(ret, ret['changes']['migrated'])
                  Severity: Major
                  Found in salt/states/lxd_container.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return _unchanged(
                    Severity: Major
                    Found in salt/states/lxd_container.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return _success(ret, ret['changes']['frozen'])
                      Severity: Major
                      Found in salt/states/lxd_container.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                            return _success(ret, ret['changes']['stopped'])
                        Severity: Major
                        Found in salt/states/lxd_container.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return _success(ret, ret['changes']['migrated'])
                          Severity: Major
                          Found in salt/states/lxd_container.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return _unchanged(ret, ret['changes']['started'])
                            Severity: Major
                            Found in salt/states/lxd_container.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return _success(ret, msg)
                              Severity: Major
                              Found in salt/states/lxd_container.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return _success(ret, 'No changes')
                                Severity: Major
                                Found in salt/states/lxd_container.py - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return _unchanged(ret, ret['changes']['frozen'])
                                  Severity: Major
                                  Found in salt/states/lxd_container.py - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                            return _unchanged(
                                    Severity: Major
                                    Found in salt/states/lxd_container.py - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                              return _error(ret, six.text_type(e))
                                      Severity: Major
                                      Found in salt/states/lxd_container.py - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                            return _success(ret, ret['changes']['started'])
                                        Severity: Major
                                        Found in salt/states/lxd_container.py - About 30 mins to fix

                                          Similar blocks of code found in 5 locations. Consider refactoring.
                                          Open

                                              try:
        container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key, verify_cert, _raw=True
        )
    except CommandExecutionError as e:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 4 other locations - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 442..450
                                          salt/states/lxd_container.py on lines 617..625
                                          salt/states/lxd_container.py on lines 718..726
                                          salt/states/lxd_image.py on lines 353..361

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 5 locations. Consider refactoring.
                                          Open

                                              try:
        container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key, verify_cert, _raw=True
        )
    except CommandExecutionError as e:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 4 other locations - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 442..450
                                          salt/states/lxd_container.py on lines 521..529
                                          salt/states/lxd_container.py on lines 617..625
                                          salt/states/lxd_image.py on lines 353..361

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 5 locations. Consider refactoring.
                                          Open

                                              try:
        container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key, verify_cert, _raw=True
        )
    except CommandExecutionError as e:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 4 other locations - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 442..450
                                          salt/states/lxd_container.py on lines 521..529
                                          salt/states/lxd_container.py on lines 718..726
                                          salt/states/lxd_image.py on lines 353..361

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 5 locations. Consider refactoring.
                                          Open

                                              try:
        container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key, verify_cert, _raw=True
        )
    except CommandExecutionError as e:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 4 other locations - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 521..529
                                          salt/states/lxd_container.py on lines 617..625
                                          salt/states/lxd_container.py on lines 718..726
                                          salt/states/lxd_image.py on lines 353..361

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                              for k in new_profiles.difference(old_profiles):
        if not __opts__['test']:
            profile_changes.append('Added profile "{0}"'.format(k))
            old_profiles.add(k)
        else:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 1 other location - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 290..295

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                              for k in old_profiles.difference(new_profiles):
        if not __opts__['test']:
            profile_changes.append('Removed profile "{0}"'.format(k))
            old_profiles.discard(k)
        else:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 1 other location - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 298..303

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 66.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                                  if running is True:
            if __opts__['test']:
                changes['running'] = 'Would start the container'
                return _unchanged(
                    ret,
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 1 other location - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 344..354

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 58.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                                  elif running is False:
            if __opts__['test']:
                changes['stopped'] = 'Would stopped the container'
                return _unchanged(
                    ret,
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 1 other location - About 2 hrs to fix
                                          salt/states/lxd_container.py on lines 332..342

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 58.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 12 locations. Consider refactoring.
                                          Open

                                          def _unchanged(ret, msg):
    ret['result'] = None
    ret['comment'] = msg
    if 'changes' not in ret:
        ret['changes'] = {}
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 11 other locations - About 1 hr to fix
                                          salt/states/lxd.py on lines 285..290
                                          salt/states/lxd.py on lines 293..298
                                          salt/states/lxd.py on lines 301..306
                                          salt/states/lxd_container.py on lines 881..886
                                          salt/states/lxd_container.py on lines 897..902
                                          salt/states/lxd_image.py on lines 381..386
                                          salt/states/lxd_image.py on lines 389..394
                                          salt/states/lxd_image.py on lines 397..402
                                          salt/states/lxd_profile.py on lines 276..281
                                          salt/states/lxd_profile.py on lines 284..289
                                          salt/states/lxd_profile.py on lines 292..297

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 12 locations. Consider refactoring.
                                          Open

                                          def _success(ret, success_msg):
    ret['result'] = True
    ret['comment'] = success_msg
    if 'changes' not in ret:
        ret['changes'] = {}
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 11 other locations - About 1 hr to fix
                                          salt/states/lxd.py on lines 285..290
                                          salt/states/lxd.py on lines 293..298
                                          salt/states/lxd.py on lines 301..306
                                          salt/states/lxd_container.py on lines 889..894
                                          salt/states/lxd_container.py on lines 897..902
                                          salt/states/lxd_image.py on lines 381..386
                                          salt/states/lxd_image.py on lines 389..394
                                          salt/states/lxd_image.py on lines 397..402
                                          salt/states/lxd_profile.py on lines 276..281
                                          salt/states/lxd_profile.py on lines 284..289
                                          salt/states/lxd_profile.py on lines 292..297

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 12 locations. Consider refactoring.
                                          Open

                                          def _error(ret, err_msg):
    ret['result'] = False
    ret['comment'] = err_msg
    if 'changes' not in ret:
        ret['changes'] = {}
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 11 other locations - About 1 hr to fix
                                          salt/states/lxd.py on lines 285..290
                                          salt/states/lxd.py on lines 293..298
                                          salt/states/lxd.py on lines 301..306
                                          salt/states/lxd_container.py on lines 881..886
                                          salt/states/lxd_container.py on lines 889..894
                                          salt/states/lxd_image.py on lines 381..386
                                          salt/states/lxd_image.py on lines 389..394
                                          salt/states/lxd_image.py on lines 397..402
                                          salt/states/lxd_profile.py on lines 276..281
                                          salt/states/lxd_profile.py on lines 284..289
                                          salt/states/lxd_profile.py on lines 292..297

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 4 locations. Consider refactoring.
                                          Open

                                              try:
        container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key, verify_cert, _raw=True
        )
    except CommandExecutionError as e:
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 3 other locations - About 1 hr to fix
                                          salt/states/lxd_container.py on lines 831..838
                                          salt/states/lxd_image.py on lines 176..182
                                          salt/states/lxd_profile.py on lines 118..124

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 4 locations. Consider refactoring.
                                          Open

                                              try:
        dest_container = __salt__['lxd.container_get'](
            name, remote_addr, cert, key,
            verify_cert, _raw=True
        )
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 3 other locations - About 1 hr to fix
                                          salt/states/lxd_container.py on lines 213..219
                                          salt/states/lxd_image.py on lines 176..182
                                          salt/states/lxd_profile.py on lines 118..124

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                              if __opts__['test']:
        ret['changes']['stopped'] = \
            'Would stop the container "{0}"'.format(name)
        return _unchanged(ret, ret['changes']['stopped'])
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 2 other locations - About 1 hr to fix
                                          salt/states/lxd_container.py on lines 552..556
                                          salt/states/lxd_container.py on lines 652..656

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                              if __opts__['test']:
        ret['changes']['started'] = (
            'Would start the container "{0}"'.format(name)
        )
        return _unchanged(ret, ret['changes']['started'])
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 2 other locations - About 1 hr to fix
                                          salt/states/lxd_container.py on lines 652..656
                                          salt/states/lxd_container.py on lines 731..734

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 3 locations. Consider refactoring.
                                          Open

                                              if __opts__['test']:
        ret['changes']['frozen'] = (
            'Would freeze the container "{0}"'.format(name)
        )
        return _unchanged(ret, ret['changes']['frozen'])
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 2 other locations - About 1 hr to fix
                                          salt/states/lxd_container.py on lines 552..556
                                          salt/states/lxd_container.py on lines 731..734

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 53.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                          Open

                                              if __opts__['test']:
        ret['changes'] = {
            'removed':
            'Container "{0}" would get deleted.'.format(name)
        }
                                          Severity: Major
                                          Found in salt/states/lxd_container.py and 1 other location - About 1 hr to fix
                                          salt/states/lxd_image.py on lines 363..368

                                          Duplicated Code

                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                          Tuning

                                          This issue has a mass of 51.

                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                          Refactorings

                                          Further Reading

                                          There are no issues that match your filters.

                                          Category
                                          Status