Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/telemetry_alert.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function present has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

def present(name, deployment_id, metric_name, alert_config, api_key=None, profile='telemetry'):
    '''
    Ensure the telemetry alert exists.

    name
Severity: Minor
Found in salt/states/telemetry_alert.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function absent has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def absent(name, deployment_id, metric_name, api_key=None, profile="telemetry"):
    '''
    Ensure the telemetry alert config is deleted

    name
Severity: Minor
Found in salt/states/telemetry_alert.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

        if __opts__['test']:
            msg = 'alert config {0} is to be created.'.format(metric_name)
            ret['comment'] = msg
            ret['result'] = None
            return ret
Severity: Major
Found in salt/states/telemetry_alert.py and 12 other locations - About 1 hr to fix
salt/states/boto_cloudtrail.py on lines 257..261
salt/states/boto_cloudwatch_alarm.py on lines 150..154
salt/states/boto_cloudwatch_alarm.py on lines 164..168
salt/states/boto_cloudwatch_event.py on lines 222..226
salt/states/boto_elasticache.py on lines 232..236
salt/states/boto_elasticsearch_domain.py on lines 308..312
salt/states/boto_iot.py on lines 378..382
salt/states/boto_sns.py on lines 117..121
salt/states/boto_vpc.py on lines 1005..1009
salt/states/boto_vpc.py on lines 1117..1121
salt/states/boto_vpc.py on lines 1200..1204
salt/states/pyrax_queues.py on lines 51..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status