Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/tomcat.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function war_deployed has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

def war_deployed(name,
                 war,
                 force=False,
                 url='http://localhost:8080/manager',
                 timeout=180,
Severity: Minor
Found in salt/states/tomcat.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File tomcat.py has 265 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage Apache Tomcat web applications
=====================================
Severity: Minor
Found in salt/states/tomcat.py - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

        return ret
    Severity: Major
    Found in salt/states/tomcat.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return ret
      Severity: Major
      Found in salt/states/tomcat.py - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status