Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/webutil.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function user_exists has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def user_exists(name, password=None, htpasswd_file=None, options='',
                force=False, runas=None, update=False):
    '''
    Make sure the user is inside the specified htpasswd file
Severity: Minor
Found in salt/states/webutil.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function user_absent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def user_absent(name, htpasswd_file=None, runas=None):
    '''
    Make sure the user is not in the specified htpasswd file

    name
Severity: Minor
Found in salt/states/webutil.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status