Sign upLogin

saltstack/salt

View on GitHub
Star
salt/states/win_lgpo.py

Summary

Maintainability
F
4 days
Test Coverage

Function set_ has a Cognitive Complexity of 141 (exceeds 5 allowed). Consider refactoring.
Open

def set_(name,
         setting=None,
         policy_class=None,
         computer_policy=None,
         user_policy=None,
Severity: Minor
Found in salt/states/win_lgpo.py - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity is too high in function set_. (56)
Open

def set_(name,
         setting=None,
         policy_class=None,
         computer_policy=None,
         user_policy=None,
Severity: Minor
Found in salt/states/win_lgpo.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

File win_lgpo.py has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Manage Windows Local Group Policy
=================================
Severity: Minor
Found in salt/states/win_lgpo.py - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        for p_name in current_policy[policy_data['output_section']]:
                        if policy_name.lower() == p_name.lower():
                            currently_set = True
                            pol_id = p_name
                            break
    Severity: Major
    Found in salt/states/win_lgpo.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if not policies_are_equal:
                        additional_policy_comments = []
                        if policy_data['policy_lookup'][policy_name]['rights_assignment'] and cumulative_rights_assignments:
                            for user in policy_data['requested_policy'][policy_name]:
                                if user not in current_policy[policy_data['output_section']][pol_id]:
      Severity: Major
      Found in salt/states/win_lgpo.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            for alias in policy_data['policy_lookup'][policy_name]['policy_aliases']:
                        log.debug('checking alias %s', alias)
                        if alias in current_policy[policy_data['output_section']]:
                            currently_set = True
                            pol_id = alias
        Severity: Major
        Found in salt/states/win_lgpo.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if isinstance(requested_policy_check, six.string_types):
                        policies_are_equal = requested_policy_check == current_policy_check
                    elif isinstance(requested_policy_check, list):
                        policies_are_equal = salt.utils.data.compare_lists(
                            requested_policy_check,
          Severity: Major
          Found in salt/states/win_lgpo.py - About 45 mins to fix

            Avoid too many return statements within this function.
            Open

                return ret
            Severity: Major
            Found in salt/states/win_lgpo.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return ret
              Severity: Major
              Found in salt/states/win_lgpo.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return ret
                Severity: Major
                Found in salt/states/win_lgpo.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return ret
                  Severity: Major
                  Found in salt/states/win_lgpo.py - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if user_policy and not isinstance(user_policy, dict):
            msg = 'The user_policy must be specified as a dict.'
            ret['result'] = False
            ret['comment'] = msg
            return ret
                    Severity: Major
                    Found in salt/states/win_lgpo.py and 1 other location - About 1 hr to fix
                    salt/states/win_lgpo.py on lines 201..205

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if computer_policy and not isinstance(computer_policy, dict):
            msg = 'The computer_policy must be specified as a dict.'
            ret['result'] = False
            ret['comment'] = msg
            return ret
                    Severity: Major
                    Found in salt/states/win_lgpo.py and 1 other location - About 1 hr to fix
                    salt/states/win_lgpo.py on lines 206..210

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 48.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status