Sign upLogin

saltstack/salt

View on GitHub
Star
salt/utils/configcomparer.py

Summary

Maintainability
C
1 day
Test Coverage

Function compare_and_update_config has a Cognitive Complexity of 61 (exceeds 5 allowed). Consider refactoring.
Open

def compare_and_update_config(config, update_config, changes, namespace=''):
    '''
    Recursively compare two configs, writing any needed changes to the
    update_config and capturing changes in the changes dict.
    '''
Severity: Minor
Found in salt/utils/configcomparer.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if namespace:
                        _namespace = '{0}{1}'.format(namespace, _namespace)
                    changes[_namespace] = {
Severity: Major
Found in salt/utils/configcomparer.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        if idx < len(config):
                        continue
                    _namespace = '[{0}]'.format(idx)
    Severity: Major
    Found in salt/utils/configcomparer.py - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

                  return config
      Severity: Major
      Found in salt/utils/configcomparer.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return config
        Severity: Major
        Found in salt/utils/configcomparer.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return update_config
          Severity: Major
          Found in salt/utils/configcomparer.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status