Sign upLogin

saltstack/salt

View on GitHub
Star
salt/utils/minion.py

Summary

Maintainability
C
1 day
Test Coverage

Function _read_proc_file has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def _read_proc_file(path, opts):
    '''
    Return a dict of JID metadata, or None
    '''
    serial = salt.payload.Serial(opts)
Severity: Minor
Found in salt/utils/minion.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return False
Severity: Major
Found in salt/utils/minion.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return data
    Severity: Major
    Found in salt/utils/minion.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return None
      Severity: Major
      Found in salt/utils/minion.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return None
        Severity: Major
        Found in salt/utils/minion.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return True
          Severity: Major
          Found in salt/utils/minion.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return None
            Severity: Major
            Found in salt/utils/minion.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return None
              Severity: Major
              Found in salt/utils/minion.py - About 30 mins to fix

                Function running has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def running(opts):
    '''
    Return the running jobs on this minion
    '''
                Severity: Minor
                Found in salt/utils/minion.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _check_cmdline has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                def _check_cmdline(data):
    '''
    In some cases where there are an insane number of processes being created
    on a system a PID can get recycled or assigned to a non-Salt process.
    On Linux this fn checks to make sure the PID we are checking on is actually
                Severity: Minor
                Found in salt/utils/minion.py - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status