Sign upLogin

saltstack/salt

View on GitHub
Star
salt/utils/validate/net.py

Summary

Maintainability
A
1 hr
Test Coverage

Function __ip_addr has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def __ip_addr(addr, address_family=socket.AF_INET):
    '''
    Returns True if the IP address (and optional subnet) are valid, otherwise
    returns False.
    '''
Severity: Minor
Found in salt/utils/validate/net.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

    return True
Severity: Major
Found in salt/utils/validate/net.py - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status