sam002/yii2-acme

View on GitHub

Showing 8 of 8 total issues

Method doIssue has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function doIssue($domains)
    {
        //validate domains
        yield \Amp\resolve($this->checkDnsRecords($domains));

Severity: Minor
Found in src/resources/Issue.php - About 1 hr to fix

    Method actionRevoke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionRevoke($name = '') {
            $acme = $this->getAcme();
            try {
                $infoSrc = $acme->info();
                $certificates = [];
    Severity: Minor
    Found in src/console/AcmeController.php - About 1 hr to fix

      Method domainsSet has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function domainsSet($domains = [])
          {
              if (empty($domains) || $this->confirm("Edit the list of domains?", false)) {
                  //force get available domains
                  $domainsSearched = array_filter(Yii::$aliases, function ($data, $key) {
      Severity: Minor
      Found in src/console/AcmeController.php - About 1 hr to fix

        Function actionRevoke has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionRevoke($name = '') {
                $acme = $this->getAcme();
                try {
                    $infoSrc = $acme->info();
                    $certificates = [];
        Severity: Minor
        Found in src/console/AcmeController.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function domainsSet has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function domainsSet($domains = [])
            {
                if (empty($domains) || $this->confirm("Edit the list of domains?", false)) {
                    //force get available domains
                    $domainsSearched = array_filter(Yii::$aliases, function ($data, $key) {
        Severity: Minor
        Found in src/console/AcmeController.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function actionRenew has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionRenew($ttl = 1) {
                $acme = $this->getAcme();
                try {
                    $infoSrc = $acme->info();
                    /* @var  Certificate $certificate */
        Severity: Minor
        Found in src/console/AcmeController.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function doIssue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function doIssue($domains)
            {
                //validate domains
                yield \Amp\resolve($this->checkDnsRecords($domains));
        
        
        Severity: Minor
        Found in src/resources/Issue.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getAcme has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getAcme()
            {
                if (!\Yii::$app->has('acme')) {
                    if($this->interactive && $this->confirm("yii2-acme has default configuration. Advanced setup?", false)) {
                        $config = $this->advanced();
        Severity: Minor
        Found in src/console/AcmeController.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language